Make "stop" retry on failure. #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
balopat
reviewed
Dec 21, 2018
balopat
reviewed
Dec 21, 2018
| @@ -105,14 +105,14 @@ func StartHost(api libmachine.API, config cfg.MachineConfig) (*host.Host, error) | |||
| func StopHost(api libmachine.API) error { | |||
| host, err := api.Load(cfg.GetMachineName()) | |||
| if err != nil { | |||
| return errors.Wrapf(err, "Error loading host: %s", cfg.GetMachineName()) | |||
| return errors.Wrapf(err, "Load: %s", cfg.GetMachineName()) | |||
There was a problem hiding this comment.
I'm wondering if we lose context here? I'd have to see the code to understand that this Load: ... error was at Stopping time?
There was a problem hiding this comment.
In this case, there is no contextual difference between "Error loading host" and "Load".
balopat
approved these changes
Dec 21, 2018
|
All failures are IngressController related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3478