-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to crio-bin v1.13.0 #3515
Conversation
@tstromberg : would you consider also include some of the config fixes ? (#3190) Especially the odd root location and storage driver name is getting in the way... Would be much better to just go with the defaults, than to make up minikube things ? root="/var/lib/containers/storage" storage_driver="overlay" It is basically the same thing, except creating a proper mount for the (standard) dir. |
I can confirm that this build still works with --kubernetes-version=v1.10.x and v1.12.x |
Good call. I'd love to see that PR get merged, so I updated the tests. I'm going to try to keep this PR as small as possible though. =) |
Sure thing (keeping this PR small), just meant before you were "done" with cri-o ? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: balopat, tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This ensures proper support for k8s v1.13:
https://github.com/kubernetes-sigs/cri-o#compatibility-matrix-cri-o---kubernetes-clusters
Also, fix broken iso-test that got in my way.