Install upstream runc into /usr/bin/docker-runc #3545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
FYI: starting with Docker 18.09, it is rather recommended to install (For minikube v0.33.1, Docker 18.06 + this PR seems fine) |
|
@AkihiroSuda - Excellent. I've added a TODO so that we can remove this hack once we can update docker to 18.09 (when all of the supported Kubernetes versions are compatible) |
dlorenc
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This links runc to docker-runc is so that Docker inside of the guest VM can get the latest runc security update.
Docker's runc doesn't have it yet, and even if it did, the latest Docker versions are not compatible with all supported Kubernetes versions. This allows us to update runc without being beholden to docker-ce release schedules and Kubernetes->docker version incompatibilities.
This will keep the actual docker-runc installed into /usr/bin/docker-runc.orig just as a reminder that strange things are afoot.
Once we move to Docker 18.09, we can drop this hack as it prefers the upstream runc binary.