remove kvm hidden state from KVM domain spec

[markllama]

This change removes a KVM feature spec that is not present and will not be in CentOS or RHEL.
The presence of this section prevented minikube from starting in KVM on those hosts.

This prior commit introduced the feature spec, breaking CentOS and RHEL: 7ba01b4

Unfortunately, RH has decided not to enable the VM hiding feature in KVM on RHEL and CentOS:
https://bugzilla.redhat.com/show_bug.cgi?id=1492173

ISSUE REFERENCE: #3546

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[minikube-bot]

Can one of the admins verify this patch?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markllama
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jimmidyson

If they are not already assigned, you can assign the PR to them by writing /assign @jimmidyson in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[markllama]

I signed it

[markllama]

/recheck

[markllama]

I signed it

[tstromberg]

@minikube-bot OK to test

[tstromberg]

Thanks for the patch!

I'm concerned that this patch may break GPU support, and unfortunately the GPU testing node is offline in our CI system. I'll need to check-in to see what the state of the testing config is to see if I can get this properly tested.

/cc @balopat

[tstromberg]

Related issue for GPU testing: #3590

[markllama]

I signed it

[gbraad]

I would suggest a way to disable this feature, instead of assuming this a default. As said, this only affects RHEL and is a choice, so disable based on feature or OS detection.

…

On Sun, Jan 27, 2019, 17:49 Mark Lamourine ***@***.*** wrote: I signed it — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3586 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAHZjskf79JSlmap9JVPZ8UfvOhOTO7ks5vHdiRgaJpZM4aS_TK> .

[markllama]

@gbraad I'd also suggest NOT making kvm hidden=true the default. At this point it won't be available in either RHEL or CentOS

[afbjorklund]

I think this already requires --gpu parameter for minikube (says #3459), so could version it on that ?

Making it an option seems like the best choice here, if half want it to be on and half want it to be off...

[afbjorklund]

Judging from the comment from the reason why it is not included, seems better as a separate --hidden.

The NVIDIA driver failing when detecting the KVM hypervisor is an indication that NVIDIA does not support this configuration and therefore neither does Red Hat.

[afbjorklund]

Should be off by default now.