-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #3253, improve kubernetes-version error string #3596
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: flyingcircle If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@minikube-bot OK to test |
Any chance of signing the CLA so that this could be merged? 📝 Instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement |
I signed it |
The bot isn't noticing the CLA signing, and says "commit missing GitHub user" c9d79f1 says the commit is by "Jeremy Hamilton" - which is presumably you, but perhaps with an e-mail address that doesn't match what GitHub has? I found this article about the problem: https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user Do you mind checking it out? My apologies for the CLA headache. |
I've switched my email. I'll see if that fixes it (primary/secondary github email?). But everything matches. |
c9d79f1 still says "Jeremy Hamilton" instead of "flyingcircle", so the CLA checker is still failing :( |
# This is the 1st commit message: Issue kubernetes#3253, improve kubernetes-version error string # This is the commit message kubernetes#2: Issue kubernetes#3253, improve kubernetes-version error string
Alright that took far too long, just ended up having to rebase, and edit my local repo's commit history. But it all looks good now. |
Thanks for seeing this one through! My apologies for the CLA being so difficult to get sorted out. |
Since the kubernetes version is used in creating the URLs to grab binaries, not including the 'v' would require adding it back in certain places. Simply adding a better error message.