Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --download-only option to start command #3737

Merged
merged 4 commits into from
Apr 11, 2019
Merged

Add --download-only option to start command #3737

merged 4 commits into from
Apr 11, 2019

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Feb 22, 2019 •
edited
Loading

Make it possible to download files without loading or installing,
and without starting the host... Download: ISO, binaries, images.

Closes #3736

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2019
@tstromberg
Copy link
Contributor

I feel like the more natural place for this would be "minikube cache --startup-images", but I also recognize that this would be really difficult to implement with the way the code is currently organized.

tstromberg
tstromberg suggested changes Mar 8, 2019
View reviewed changes
cmd/minikube/cmd/cache.go Outdated Show resolved Hide resolved
cmd/minikube/cmd/start.go Outdated
if err := LoadCachedImagesInConfigFile(false); err != nil {
exit.WithError("Failed to cache images", err)
}
console.OutStyle("check", "Download complete and in download only mode")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just "Download complete!" would suffice as a console message.

pkg/minikube/bootstrapper/bootstrapper.go Outdated Show resolved Hide resolved
@afbjorklund
Copy link
Collaborator Author

I thought minikube cache was mostly used to add extra stuff, not for Kubernetes itself ?
The name of the parameter (and the idea) was mostly modelled after "apt-get upgrade"....

@tstromberg
Copy link
Contributor

Just checking if you plan to address the comments so that this will be merged before 1.0?

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Mar 23, 2019 •
edited
Loading

Working on it, think that it needs to be rewritten to match the caching of images better.

@afbjorklund afbjorklund requested a review from tstromberg March 23, 2019 17:07
@tstromberg tstromberg added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2019
@afbjorklund
Refactor: move cache calls into separate functions
adcbcf1 
Need to split out the caching functions, from the loading/copying.

Also need to make the lists accessible from outside the functions.
@afbjorklund
Move the cache functions from kubeadm to machine
54f68e0
@afbjorklund
Add --download-only option to start command
0ebfe46 
Make it possible to download files without loading or installing,
and without starting the host... Download: ISO, binaries, images.
@afbjorklund afbjorklund removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2019
@afbjorklund afbjorklund mentioned this pull request Mar 26, 2019
Merged
@tstromberg tstromberg added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2019
@tstromberg
Copy link
Contributor

Please merge once rebased. Thanks!

@tstromberg tstromberg merged commit f9bf001 into kubernetes:master Apr 11, 2019
@11janci 11janci mentioned this pull request Apr 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@balopat balopat Awaiting requested review from balopat

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afbjorklund @k8s-ci-robot @tstromberg