Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When missing a hypervisor, omit the bug report prompt #3787

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

afbjorklund
Copy link
Collaborator

Show a friendly link to the documentation instead

@afbjorklund afbjorklund requested a review from tstromberg March 4, 2019 19:27
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2019
@k8s-ci-robot k8s-ci-robot requested a review from balopat March 4, 2019 19:27
@tstromberg
Copy link
Contributor

I think this hard-coded approach is a great initial look at the problem. Thanks!

I can easily see this growing into a proper table of solutions for common problems, defined in a YAML file, perhaps even one that could even be referenced & updated between releases.

@tstromberg tstromberg merged commit 79c1e7d into kubernetes:master Mar 5, 2019
@tstromberg tstromberg changed the title Failure to read documentation isn't really a crash If the user is missing a hypervisor, don't prompt the user to file a bug report. Mar 5, 2019
@tstromberg tstromberg changed the title If the user is missing a hypervisor, don't prompt the user to file a bug report. When missing a hypervisor, omit the bug report prompt Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants