Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CHANGE_MINIKUBE_NONE_USER regression from recent changes #3875

Merged
merged 1 commit into from
Mar 21, 2019
Merged

fix CHANGE_MINIKUBE_NONE_USER regression from recent changes #3875

merged 1 commit into from
Mar 21, 2019

Conversation

steved
Copy link
Contributor

@steved steved commented Mar 14, 2019

6c48048 changed the order of the startup script so that now the CHANGE_MINIKUBE_NONE_USER chown doesn't actually kick in after the files are added. I didn't re-add it exactly where it was before (right before bootstrapCluster), but after the provisioning is complete.

I believe #3751 is this issue, as well.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: steved
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: luxas

If they are not already assigned, you can assign the PR to them by writing /assign @luxas in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 14, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

6c48048 changed the order of the
startup script so that now the CHANGE_MINIKUBE_NONE_USER `chown` doesn't
actually kick in after the files are added.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 14, 2019
@tstromberg tstromberg merged commit 2579c73 into kubernetes:master Mar 21, 2019
@steved steved deleted the fix-change-user-none branch March 22, 2019 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants