Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solution catalog to help users who run into known problems #3931

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Mar 22, 2019

This extracts the nascent problem detection code from exit.go, and formalizes it in into a package that we can use for the upcoming network preflights (#3145).

Example output:

😄  minikube v0.35.0 on darwin (amd64)
🤹  Downloading Kubernetes v1.13.4 images in the background ...
🔥  Creating virtualbox VM (CPUs=2, Memory=2048MB, Disk=20000MB) ...

💣  Unable to start VM
> Error:         [VBOX_NOT_FOUND] create: precreate: VBoxManage not found. Make sure VirtualBox is installed and VBoxManage is in the path
> Solution:      Install VirtualBox, ensure that VBoxManage is executable and in path, or select an alternative value for --vm-driver
> Documentation: https://www.virtualbox.org/wiki/Downloads
> Related issues:
  - https://github.com/kubernetes/minikube/issue/3784
  - https://github.com/kubernetes/minikube/issue/3776

😿  If the solution does not help, please let us know:
👉  https://github.com/kubernetes/minikube/issues/new

This also renames exit.WithProblems to exit.WithLogEntries to avoid the terminology mismatch.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 22, 2019
@k8s-ci-robot k8s-ci-robot requested review from balopat and dlorenc March 22, 2019 04:47
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2019
@tstromberg tstromberg requested review from afbjorklund and sharifelgamal and removed request for dlorenc March 22, 2019 04:57
@tstromberg tstromberg changed the title Add problem/solution catalog Add problem/solution catalog to give users actionable feedback on errors Mar 22, 2019
@tstromberg tstromberg changed the title Add problem/solution catalog to give users actionable feedback on errors Add solution catalog to help users who run into known problems Mar 22, 2019
Copy link
Collaborator

@afbjorklund afbjorklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! This should hopefully cut down on the amount on "VM lost" and "Corporate proxy" issues ?

import "regexp"

// r is a shortcut around regexp.MustCompile
func r(s string) *regexp.Regexp {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe call this "re()", or perhaps that is just me mixing it with r'' raw strings (from python...)

@tstromberg tstromberg merged commit a131747 into kubernetes:master Mar 26, 2019
@tstromberg tstromberg deleted the bring_ya_errs_to_the_project_maybe_we_can_solve_it branch March 26, 2019 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants