Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Makefile VERSION to v1.0.0 #3969

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Bump Makefile VERSION to v1.0.0 #3969

merged 1 commit into from
Mar 26, 2019

Conversation

tstromberg
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2019
@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

@tstromberg tstromberg changed the title Bump Makefile VERSION to v1.0.0 WIP: Bump Makefile VERSION to v1.0.0 Mar 26, 2019
@tstromberg
Copy link
Contributor Author

This failure will require some investigation:

    --- FAIL: TestFunctional/Mounting (7.01s)
        mount_test.go:133: Unable to stat fromhost via SSH. error exit status 1, stat: cannot stat '/mount-9p/fromhost': Permission denied
            ssh: Process exited with status 1

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2019
balopat
balopat approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) this was probably not the reason the tests are failing...

@tstromberg tstromberg merged commit 1e8bd6f into kubernetes:master Mar 26, 2019
@tstromberg tstromberg changed the title WIP: Bump Makefile VERSION to v1.0.0 Bump Makefile VERSION to v1.0.0 Mar 26, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2019
@tstromberg tstromberg mentioned this pull request Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tstromberg @k8s-ci-robot @balopat