adding kubectl test for minikube

[ramitsurana]

No description provided.

[minikube-bot]

Can one of the admins verify this patch?

[dlorenc]

Can you switch this to something like:

glog.Errorln("Kubectl is not installed.")
os.Exit(1)

[dlorenc]

Actually lets just leave this as a warning, kubectl isn't the only way to interact with kubernetes so we shouldn't error if the user doesn't have it installed.

[jimmidyson]

Wonder if we can add a better help message to direct where to download it from?

[ramitsurana]

Thanks @jimmidyson for the suggestion.I will add some nice suggestion for kubectl.

[dlorenc]

Thanks for the PR! I left a few comments.

[ramitsurana]

Thanks @dlorenc I knew it needed improvement ! I will make the changes accordingly.

[ramitsurana]

I was wondering if the url can be shortened.

[dlorenc]

Could you drop the os.Exit(1) here? I think this should just log a warning instead of an error.

[dlorenc]

Ah sorry, you'll need:

if _, err := exec.LookPath("kubectl"); err != nil {

[ramitsurana]

Still Failing :( .Could you please check again ?

[jberkus]

This is a good first step. However:

1. we also need to verify the version of Kubectl.
2. I'll argue that we should simply download and install it instead of forcing users to take multiple steps to do it themselves.

[aaron-prindle]

@ramitsurana the travis test is failing due to the file format not being compliant with gofmt:

From Travis:

Checking gofmt...
--- /dev/fd/63  2016-07-27 16:37:29.696912317 +0000
+++ /dev/fd/62  2016-07-27 16:37:29.696912317 +0000
@@ -0,0 +1 @@
+cmd/minikube/cmd/start.go
make: *** [test] Error 1

The file difference:

aprindle@aprindle:~/go/src/k8s.io/minikube/cmd/minikube/cmd$ gofmt -d start.go
diff start.go gofmt/start.go
--- /tmp/gofmt123843528 2016-07-27 15:07:32.963388318 -0700
+++ /tmp/gofmt412009607 2016-07-27 15:07:32.963388318 -0700
@@ -106,11 +106,10 @@
        //Checking for kubectl
        fmt.Printf("Checking for Kubectl ...\n")
        if _, err := exec.LookPath("kubectl"); err != nil {
-               glog.Errorln("For more info on kubectl visit http://kubernetes.io/docs/getting-started-guides/minikube/#download-kubectl")
+               glog.Errorln("For more info on kubectl visit http://kubernetes.io/docs/getting-started-guides/minikube/#download-kubectl")
        }
        fmt.Printf("Kubectl is configured and installed.")
-
-
+
        // setup kubeconfig
        name := constants.MinikubeContext
        certAuth := constants.MakeMiniPath("ca.crt")

To fix this, run gofmt on start.go with:

gofmt -w start.go

[dlorenc]

This is a good first step. However:

we also need to verify the version of Kubectl.

I'll argue that we should simply download and install it instead of forcing users to take multiple steps to do it themselves.

Yeah, we plan on bundling kubectl. Right now we're holding off until we get our installer story straightened out, that work is tracked here: #402

[dlorenc]

I'm going to close this for now. Please re-open if you get some time to finish it!