Add automatic locale detection #4199
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Can one of the admins verify this patch? |
sharifelgamal
added
the
do-not-merge/work-in-progress
sharifelgamal
removed
the
do-not-merge/work-in-progress
pkg/minikube/console/console.go
Outdated
| @@ -88,14 +89,20 @@ func OutStyle(style, format string, a ...interface{}) error { | |||
|
|
|||
| // Out writes a basic formatted string to stdout | |||
| func Out(format string, a ...interface{}) error { | |||
| locale, err := jibber_jabber.DetectIETF() | |||
There was a problem hiding this comment.
Do you mind taking some Go benchmarks to see how if this adversely affects the Out() call performance?
If so, perhaps we should move the preferred language setup to cmd/minikube/main.go.
cmd/minikube/cmd/start.go
Outdated
| @@ -691,3 +693,12 @@ func saveConfig(clusterConfig cfg.Config) error { | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| func determineLocale() { | |||
There was a problem hiding this comment.
This should be in main.go, so that it affects all commands, rather than just minikube start.
There was a problem hiding this comment.
Makes sense. done.
Fixes #4183