Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kvm network name validation #4380

Merged
merged 1 commit into from
Jun 15, 2019

Conversation

josedonizetti
Copy link
Member

Fix for #3581

I think it makes sense to validate this inside the driver. But maybe we could also add a check on the cli for the --kvm-network flag. WDYT?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 30, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @josedonizetti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: josedonizetti
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: balopat

If they are not already assigned, you can assign the PR to them by writing /assign @balopat in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@tstromberg
Copy link
Contributor

Thanks again for all of these fixes. I feel much better about the kvm2 driver now. It may very well become our most robust driver after all this.

@RA489
Copy link

RA489 commented May 31, 2019

@minikube-bot OK to test

@RA489
Copy link

RA489 commented May 31, 2019

@josedonizetti please squash the commit to one

@josedonizetti josedonizetti force-pushed the add-kvm-network-validation branch from cf7cfe0 to 9db0975 Compare May 31, 2019 16:36
@josedonizetti
Copy link
Member Author

@RA489 commit squashed

@RA489
Copy link

RA489 commented Jun 1, 2019

@josedonizetti Thanks!

@afbjorklund
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 6, 2019
@sharifelgamal
Copy link
Collaborator

@minikube-bot OK to test

@medyagh
Copy link
Member

medyagh commented Jun 15, 2019

/retest this please

@medyagh
Copy link
Member

medyagh commented Jun 15, 2019

The failing test is related to this flaky test #4501

@medyagh medyagh merged commit a2d844e into kubernetes:master Jun 15, 2019
@josedonizetti josedonizetti deleted the add-kvm-network-validation branch June 16, 2019 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants