Added option to delete all profiles #4780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added skeleton for IsProfileConfigValid
Added skeleton for deleteAllProfiles function
Renamed hasConfigJson to hasConfigJSON
…DELETE_ALL_PROFILES
|
Welcome @marekschwarz! |
k8s-ci-robot
added
do-not-merge/work-in-progress
|
Hi @marekschwarz. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
size/L
|
Can one of the admins verify this patch? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: marekschwarz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reply |
k8s-ci-robot
added
cncf-cla: yes
Travis tests have failedHey @marekschwarz, 1st Buildmake testTravisBuddy Request Identifier: 3998aec0-e615-11e9-82e3-2501c7641175 |
|
@medyagh The two machines that should be valid are flagged as invalid with this error message: |
Travis tests have failedHey @marekschwarz, 1st Buildmake testTravisBuddy Request Identifier: 2978dbd0-e61c-11e9-82e3-2501c7641175 |
seems like we need to do a refactor in minikube to not rely on globals |
my guess is unit tests are run in parallel in travis and that setting MINIKUBE_HOME env causes different tests to interfere. as far I as I remember we had parameterized most of the minikube's code to accept minikube_home as a parameter so we dont have to set them in the tests... have you already tried that ? (not setting env but passing a parameter?) |
Removed debug code
|
@medyagh The problem was that I used hyperkit as driver in my testfiles and hyperkit seems to be not available on the travis-ci testmachine. |
I see... I will have to review the test again, to make sure its reasonable for unit test to look for driver at all |
|
it is a progress though you passed the unit tests ! congrats and thanks for not giving up ! |
|
@marekschwarz here are couple things to do and then I think this PR will be ready for merge. we need to add integration tests for all the new features of minikube. my recommendation 2- also add a minikube delete all command to the script that runs integration tests after all tests run. https://github.com/kubernetes/minikube/blob/master/hack/jenkins/common.sh#L109 |
|
3- also please add documentation to the website, how to use this new command. |
|
@marekschwarz I think you are close to deliver it :) maybe we can deliver this in this release ! |
|
@medyagh sorry, I didn‘t find the time to do something in the last few days. I will try to implement the missing stuff tomorrow :) |
|
@marekschwarz Awesome, one thing that I would like to take a look, is making sure the testdata organization is consistent. the rules of thumbs:
|
Travis tests have failedHey @marekschwarz, 1st Buildmake testTravisBuddy Request Identifier: 0e53f060-eb94-11e9-b736-db238f783907 |
Run delete --all after start_stop_delete_test
Where can I add the documentation? |
Codecov Report
@@ Coverage Diff @@
## master #4780 +/- ##
==========================================
+ Coverage 36.89% 37.23% +0.33%
==========================================
Files 102 103 +1
Lines 7369 7528 +159
==========================================
+ Hits 2719 2803 +84
- Misses 4297 4352 +55
- Partials 353 373 +20
|
minikube website. https://github.com/kubernetes/minikube/tree/master/site/content/en/docs maybe find where the delete command is documented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4668