Upgrade nginx ingress to 0.25.0

[reegnz]

No description provided.

[k8s-ci-robot]

Welcome @reegnz!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @reegnz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: reegnz
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[tstromberg]

Looks good. Thank you!

[tstromberg]

@minikube-bot OK to test

[medyagh]

/retest this please

[medyagh]

Thanks fort this contribution, @reegnz
I am curious, was there any issue with the current version that motivated you to update the version ? (not that I don't like newer verison but I am just curious if users were facing an issue that I should be aware of ? )

[tstromberg]

Marking as WIP, as it appears that the integration test may need to be adjusted:

 --- FAIL: TestFunctional/IngressController (102.33s)
        addons_test.go:165: ExpectedStr sshCmdOutput to be: Welcome to nginx!. Output was: curl: (56) Recv failure: Connection reset by peer

See https://github.com/kubernetes/minikube/blob/master/docs/contributors/build_guide.md#integration-tests for some guidance.

[RA489]

@minikube-bot OK to test

[reegnz]

@medyagh there had been a few new features in the ingress-controller that I am want to use in minikube:

• external-auth turned from opt-in to opt-out
• validating webhook for ingress resources

Especially the secure-by-default thingy is something we want to use in production, and it would be great to be able to use in our devenv as well with the minikube default ingress plugin.

[reegnz]

@tstromberg I'll get onto fixing the integration tests then.

[RA489]

@reegnz please fix the integration test rest LGTM.

[reegnz]

@tstromberg that is a weird failure for the integration test, it's a generic curl failure message.
I will try and debug, since I have a feeling this is an issue on the ingress-contoller side.

What's hard in this case is that the ingress controller logs aren't available for debugging, so I have to reproduce that myself -> maybe improve on the test logging in case of errors.

[reegnz]

It seems like something regarding ClusterRoles has changed:

E0722 08:41:12.989145       6 reflector.go:125] pkg/mod/k8s.io/client-go@v0.0.0-20190612125919-78d2af7/tools/cache/reflector.go:98: Failed to list *v1beta1.Ingress: ingresses.networking.k8s.io is forbidden: User "system:serviceaccount:kube-system:nginx-ingress" cannot list resource "ingresses" in API group "networking.k8s.io" at the cluster scope.

Checking the difference between upstream ingress-controller manifests and the ones in minikube.

(suggestion: instead of maintaining it's own set of manifests, minikube should kustomize the upstream resources instead).

[reegnz]

@medyagh please check again, everything should be in order now.

[medyagh]

looks good to me ! thank you for this contribution !