Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression caused by registry-proxy #4805

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Fix regression caused by registry-proxy #4805

merged 1 commit into from
Jul 18, 2019

Conversation

kumarom
Copy link
Contributor

@kumarom kumarom commented Jul 18, 2019 •
edited
Loading

This PR addresses #4604 by adding a new selector to concerned svc/rc only.
This also reverts kubernetes.io/minikube-addons to registy for registry-proxy
so that addon manager can deploy registry-proxy when registry addon is enabled.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 18, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @kumarom. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kumarom
To complete the pull request process, please assign ra489
You can assign the PR to them by writing /assign @ra489 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@kumarom kumarom mentioned this pull request Jul 18, 2019
Closed
@kumarom kumarom force-pushed the registry-proxy-fix branch from 743c64f to 55cd455 Compare July 18, 2019 12:17
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 18, 2019
@kumarom
Fix regression caused by registry-proxy
d76d874 
This PR addresses kubernetes#4604 by adding a new selector to concerned svc/rc only.
This also reverts `kubernetes.io/minikube-addons` to `registy` for registry-proxy
so that addon manager can deploy registry-proxy when registry addon is enabled.
@kumarom kumarom force-pushed the registry-proxy-fix branch from 55cd455 to d76d874 Compare July 18, 2019 12:58
@tstromberg
Copy link
Contributor

Thank you for fixing this!

@tstromberg tstromberg merged commit 2e4ee08 into kubernetes:master Jul 18, 2019
This was referenced Jul 19, 2019
Closed
Closed
Merged
@kumarom kumarom deleted the registry-proxy-fix branch July 23, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kumarom @k8s-ci-robot @minikube-bot @tstromberg