Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cheggaaa/pb from v1.0.27 to v3.0.1 #5025

Merged

Conversation

blueelvis
Copy link
Contributor

Fixes #4996

Tested on the following -

  1. Windows CMD
    image
  2. Windows PowerShell
    image
  3. Git for Bash Terminal (With default size)
    image

Although, as of now, I still don't have any idea why we are locking and unlocking with the mutex. Could someone please explain?

Please try on your local as well.

-Pranav

@blueelvis blueelvis requested a review from tstromberg August 8, 2019 22:39
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: blueelvis
To complete the pull request process, please assign sharifelgamal
You can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @blueelvis. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 8, 2019
pkg/util/progressbar.go Outdated Show resolved Hide resolved
@tstromberg tstromberg changed the title Fixed the progress bars ^_^ Upgrade cheggaaa/pb (progressbar) library from v1.0.27 to v3.0.1 Aug 8, 2019
@tstromberg tstromberg changed the title Upgrade cheggaaa/pb (progressbar) library from v1.0.27 to v3.0.1 Upgrade cheggaaa/pb from v1.0.27 to v3.0.1 Aug 8, 2019
@tstromberg
Copy link
Contributor

Thank you!!!

@tstromberg tstromberg added this to the v1.3.1 milestone Aug 9, 2019
@cvila84
Copy link

cvila84 commented Aug 9, 2019

Great !

@RA489
Copy link

RA489 commented Aug 11, 2019

@minikube-bot Ok to test

@tstromberg
Copy link
Contributor

Thanks!

@tstromberg tstromberg merged commit 345ed1b into kubernetes:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create a new VM on git bash or cygwin
5 participants