Remove heapster addon #5243
Merged
Remove heapster addon #5243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
|
Hi @rajalokan. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rajalokan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Can one of the admins verify this patch? |
Travis tests have failedHey @rajalokan, 1st Buildmake testTravisBuddy Request Identifier: 2ef9c570-cd66-11e9-a9d8-278aeb0f3435 |
|
|
|
Any luck sorting out the test failure? You should be able to confirm it locally by running:
|
|
Let me try it out in a day. Missed out on it. Please give me a day.
…On Fri, 6 Sep 2019, 22:16 Thomas Strömberg, ***@***.***> wrote:
Any luck sorting out the test failure?
You should be able to confirm it locally by running:
make test
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5243?email_source=notifications&email_token=AAMMR46JQPJXJ4B5VYL5EA3QIKCORA5CNFSM4IS3R5PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6DM5LA#issuecomment-528928428>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMMR432B3RWJEWR7DA55STQIKCORANCNFSM4IS3R5PA>
.
|
rajalokan
force-pushed
the
remove-heapster
branch
from
2c34404 to
53ba7e6
Compare
|
Hi @tstromberg Can you please take a look when you can. |
|
@rajalokan please rebase from origin/master and resolve conflicts |
rajalokan
force-pushed
the
remove-heapster
branch
from
53ba7e6 to
0eb1eb9
Compare
|
@woodcockjosh Done. Thanks for the review. |
rajalokan
force-pushed
the
remove-heapster
branch
from
0eb1eb9 to
3f0f2b4
Compare
Codecov Report
@@ Coverage Diff @@
## master #5243 +/- ##
==========================================
- Coverage 38.06% 37.83% -0.24%
==========================================
Files 103 103
Lines 7540 7589 +49
==========================================
+ Hits 2870 2871 +1
- Misses 4293 4341 +48
Partials 377 377
|
|
/assign rajalokan |
|
@minikube-bot OK to test |
rajalokan
force-pushed
the
remove-heapster
branch
from
3f0f2b4 to
428cb32
Compare
|
This PR looks ready to merge, just needs one fix. Change the |
rajalokan
force-pushed
the
remove-heapster
branch
2 times, most recently
from
4f3e3f6 to
7328332
Compare
Fixes kubernetes#5017. As per discussion, needed a rebase and this PR is rebased to latest master.
rajalokan
force-pushed
the
remove-heapster
branch
from
7328332 to
64f1e73
Compare
|
@sharifelgamal Can you please take a look. |
|
Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5017. As per discussion, needed a rebase and this PR is rebased
to latest master.