-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change systemd unit files perm to 644 #5492
Conversation
systemd complains about the conf file is not world-inaccessible Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Hi @laozc. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: laozc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I am curious is there a related issue you could reference? I like to see the before and after and how this PR would fix the issue |
Not sure if there is a pending issue filed for it.
It simply suppresses this systemd warning. |
Thank you for providing the reason, could you verify that after this PR the warning goes away ? if you could prove me that ! I am okay with this being merged ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could provide me logs that the gvisor warrning goes away after this PR. I approve.
@medyagh You may check the enclosed log (
|
@minikube-bot OK to test |
systemd complains about the conf file is not world-inaccessible
Signed-off-by: Zhongcheng Lao Zhongcheng.Lao@microsoft.com