-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added flags to purge configuration with minikube delete #5548
Added flags to purge configuration with minikube delete #5548
Conversation
Hi @blueelvis. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: blueelvis The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Travis tests have failedHey @blueelvis, 1st Buildmake test
TravisBuddy Request Identifier: b1819960-e827-11e9-b0f4-939d566b92ab |
Codecov Report
@@ Coverage Diff @@
## master #5548 +/- ##
==========================================
- Coverage 37.7% 37.64% -0.07%
==========================================
Files 103 103
Lines 7617 7630 +13
==========================================
Hits 2872 2872
- Misses 4368 4380 +12
- Partials 377 378 +1
|
/ok-to-test |
# Conflicts: # cmd/minikube/cmd/delete.go # pkg/minikube/cluster/cluster.go
Fixes #5358