Fix links by using Hugo modules tag #5702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @nanikjava. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
Can one of the admins verify this patch? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nanikjava The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #5702 +/- ##
=======================================
Coverage 37.83% 37.83%
=======================================
Files 106 106
Lines 7773 7773
=======================================
Hits 2941 2941
Misses 4452 4452
Partials 380 380 |
|
@nanikjava thanks for spotting the broken link the preview shows the link is still broken see https://deploy-preview-5702--kubernetes-sigs-minikube.netlify.com/ |
WIll take a look at it, as running it locally it works so there must be some configuration that I'm not using properly. |
|
@medyagh did some more changes to the configuration and tested it works fine. Let me know how it looks on your end. Thanks |
|
@nanikjava it is still broken, you can see the Preview by clicking on the |
Travis tests have failedHey @nanikjava, 1st Buildmake testTravisBuddy Request Identifier: 21ca9ff0-f5d4-11e9-a1fe-396a3052531f |
@medyagh I've setup netlify to read from my minikube repo will investigate it. Meantime can you tell me configuration that minikube is using so can configure it the same. This is what my account looks like
|
|
Posted too soon, found the netlify.toml file inside the source code. |
|
@nanikjava you dont have to setup netlifty on your account, on this PR bellow, you can have a preview per PR. you can click on Details infront of deploy/netlify. I know it is a bit hard to find first time.
|
|
I am glad now it is LESS broken than before, but it is still broken in a way, that the MD file shows as Raw when you click on gvisor addon . this PR is for sure a step better than what it is already ! is there an way we could make the Markdown file for gvisor not look raw ? |
|
@nanikjava thank you so much for finding a way to fix that ! one small thing left, at least on my browser, the top part of the gvisor readme is not visible. If you find a way to fix this, I believe it can be applied to all other embedded .MD files.
Thanks again |
k8s-ci-robot
added
size/M
The link is broken as the config.toml is not using module.mounts. To fix this need to add [module] section to point to the deploy/ folder as the README.md files are inside that folder Put the different directory as separate module.mount and upgrade hugo version to 0.59.0
|
Thank you so much @nanikjava for doing this ! this will make a difference on users experience ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5696
The link is broken as the config.toml is not using module.mounts.
To fix this need to add [module] section to point to the deploy/ folder as the README.md files are inside that folder