Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint error: File is not goimports -ed #5721

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Fix lint error: File is not goimports -ed #5721

merged 1 commit into from
Oct 24, 2019

Conversation

govargo
Copy link
Contributor

@govargo govargo commented Oct 24, 2019

What type of PR is this?

/kind bug
/kind failing-test

What this PR does / why we need it:

There is lint error. File is not goimports -ed.
This PR fixes its lint error.

Which issue(s) this PR fixes:

Fixes #5720

Does this PR introduce a user-facing change?

No. This PR changes goimports only.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 24, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @govargo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: govargo
To complete the pull request process, please assign sharifelgamal
You can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

Codecov Report

Merging #5721 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5721   +/-   ##
=======================================
  Coverage   37.83%   37.83%           
=======================================
  Files         102      102           
  Lines        7601     7601           
=======================================
  Hits         2876     2876           
  Misses       4347     4347           
  Partials      378      378

@govargo
Copy link
Contributor Author

govargo commented Oct 24, 2019

/assign @sharifelgamal

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@medyagh
Copy link
Member

medyagh commented Oct 24, 2019

the flake test I see for TestStartStop/group/crio , is same as on the on I see on Master. it doesnt seem to be related to this PR.

#5723

@tstromberg tstromberg merged commit 0cef1a2 into kubernetes:master Oct 24, 2019
@govargo govargo deleted the fix-goimports-lint branch October 25, 2019 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LINT ERROR(make test): File is not goimports-ed, pkg/minikube/registry/drvs/{vmwarefusion, hyperkit}/driver.go
7 participants