-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lint error: File is not goimports
-ed
#5721
Conversation
Hi @govargo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: govargo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #5721 +/- ##
=======================================
Coverage 37.83% 37.83%
=======================================
Files 102 102
Lines 7601 7601
=======================================
Hits 2876 2876
Misses 4347 4347
Partials 378 378 |
/assign @sharifelgamal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good !
@minikube-bot OK to test |
the flake test I see for TestStartStop/group/crio , is same as on the on I see on Master. it doesnt seem to be related to this PR. |
What type of PR is this?
/kind bug
/kind failing-test
What this PR does / why we need it:
There is lint error.
File is not goimports -ed
.This PR fixes its lint error.
Which issue(s) this PR fixes:
Fixes #5720
Does this PR introduce a user-facing change?
No. This PR changes goimports only.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: