Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Docker open-files limit ( 'ulimit -n') to be consistent with other runtimes #5761

Merged
merged 6 commits into from
Oct 29, 2019

Conversation

tstromberg
Copy link
Contributor

Work in progress, designed to fix #5751

Unfortunately, there did not appear to be a viable approach that does not involve programming each container runtime. Thankfully, it seems like only Docker diverged.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 29, 2019
@tstromberg tstromberg changed the title Consistently set 'ulimit -n' (open file limit) across runtimes WIP: Consistently set 'ulimit -n' (open file limit) across runtimes Oct 29, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2019
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2019
@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

Merging #5761 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5761      +/-   ##
==========================================
- Coverage   37.86%   37.81%   -0.05%     
==========================================
  Files         106      106              
  Lines        7796     7806      +10     
==========================================
  Hits         2952     2952              
- Misses       4464     4475      +11     
+ Partials      380      379       -1
Impacted Files Coverage Δ
cmd/minikube/cmd/service.go 21.21% <0%> (-4.72%) ⬇️
cmd/minikube/cmd/config/open.go 13.46% <0%> (-1.76%) ⬇️
pkg/minikube/service/service.go 77% <0%> (+0.81%) ⬆️

pkg/provision/buildroot.go Outdated Show resolved Hide resolved
@tstromberg tstromberg changed the title WIP: Consistently set 'ulimit -n' (open file limit) across runtimes Set Docker open-files limit ( 'ulimit -n') to be consistent with other runtimes Oct 29, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2019
pkg/minikube/cruntime/cruntime.go Outdated Show resolved Hide resolved
pkg/provision/buildroot.go Outdated Show resolved Hide resolved
pkg/provision/buildroot.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2019
@tstromberg tstromberg merged commit 983dc16 into kubernetes:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.5 ISO: mysqld failed while attempting to check config: command was: mysqld --verbose --help
5 participants