Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message when selected driver is incompatible with existing cluster #5854

Merged
merged 2 commits into from
Nov 11, 2019

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Nov 6, 2019

Before:

😄  minikube v1.5.2 on Debian rodete
💥  The existing "minikube" VM that was created using the "kvm2" driver, and is incompatible with the "none" driver.
👉  To proceed, either:
      1) Delete the existing VM using: 'minikube delete'
      or
      2) Restart with the existing driver: 'minikube start --vm-driver=kvm2'

After:

😄  minikube v1.5.2 on Debian rodete
💥  The existing "minikube" cluster was created using the "kvm2" driver, and cannot be started using the "none" driver.
👉  To proceed, either:

    1) Delete the existing "minikube" cluster using: 'minikube delete'

    * or *

    2) Start the existing "minikube" cluster using: 'minikube start --vm-driver=kvm2'
	
💣  Exiting.

I believe the previous message may have been confusing to users, based on the context in #5828

/cc @a1exus

@k8s-ci-robot
Copy link
Contributor

@tstromberg: GitHub didn't allow me to request PR reviews from the following users: a1exus.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Before:

😄  minikube v1.5.2 on Debian rodete
💥  The existing "minikube" VM that was created using the "kvm2" driver, and is incompatible with the "none" driver.
👉  To proceed, either:
     1) Delete the existing VM using: 'minikube delete'
     or
     2) Restart with the existing driver: 'minikube start --vm-driver=kvm2'

After:

😄  minikube v1.5.2 on Debian rodete
💥  The existing "minikube" cluster that was created using the "kvm2" driver, and cannot be started using the "none" driver.
👉  To proceed, either:

   1) Delete the existing "minikube" cluster using: 'minikube delete'

   * or *

   2) Start the existing "minikube" cluster using: 'minikube start --vm-driver=kvm2'
  
💣  Exiting.

I believe the previous message may have been confusing to users, based on the context in #5828

/cc @a1exus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2019
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 6, 2019
@codecov-io
Copy link

codecov-io commented Nov 7, 2019

Codecov Report

Merging #5854 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5854      +/-   ##
==========================================
- Coverage   36.53%   36.52%   -0.01%     
==========================================
  Files         110      110              
  Lines        8116     8117       +1     
==========================================
  Hits         2965     2965              
- Misses       4762     4763       +1     
  Partials      389      389
Impacted Files Coverage Δ
cmd/minikube/cmd/start.go 19.97% <0%> (-0.03%) ⬇️

@minikube-bot
Copy link
Collaborator

Error: running mkcmp: exit status 1

@medyagh
Copy link
Member

medyagh commented Nov 8, 2019

I like the new format and space between lines. We need. More of this easy to read solution message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants