-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve message when selected driver is incompatible with existing cluster #5854
Conversation
@tstromberg: GitHub didn't allow me to request PR reviews from the following users: a1exus. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #5854 +/- ##
==========================================
- Coverage 36.53% 36.52% -0.01%
==========================================
Files 110 110
Lines 8116 8117 +1
==========================================
Hits 2965 2965
- Misses 4762 4763 +1
Partials 389 389
|
Error: running mkcmp: exit status 1 |
I like the new format and space between lines. We need. More of this easy to read solution message |
Before:
After:
I believe the previous message may have been confusing to users, based on the context in #5828
/cc @a1exus