Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dont merge]none without Docker installed: sudo systemctl start docker: exit stat… #6016

Closed
wants to merge 1 commit into from

Conversation

RA489
Copy link

@RA489 RA489 commented Dec 5, 2019

none without Docker installed: sudo systemctl start docker: exit status 5
fixes #5532

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RA489

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019
@codecov-io
Copy link

Codecov Report

Merging #6016 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6016   +/-   ##
=======================================
  Coverage   36.18%   36.18%           
=======================================
  Files         110      110           
  Lines        8214     8214           
=======================================
  Hits         2972     2972           
  Misses       4851     4851           
  Partials      391      391
Impacted Files Coverage Δ
pkg/minikube/problem/err_map.go 100% <ø> (ø) ⬆️

@afbjorklund
Copy link
Collaborator

It’s not the only supported runtime, it is just a bug that requires you to have the docker client installed (unused).

@medyagh
Copy link
Member

medyagh commented Dec 21, 2019

I don't think this is the best way to handle this !
if something is required we should check before.

in this case, the none driver does not need docker.

@k8s-ci-robot
Copy link
Contributor

@RA489: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2019
@medyagh medyagh changed the title none without Docker installed: sudo systemctl start docker: exit stat… [dont merge]none without Docker installed: sudo systemctl start docker: exit stat… Dec 21, 2019
@medyagh medyagh closed this Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

none without Docker installed: sudo systemctl start docker: exit status 5
5 participants