-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add use-local-cached-images option. #6105
feat: add use-local-cached-images option. #6105
Conversation
Can one of the admins verify this patch? |
Welcome @Colstuwjx! |
Hi @Colstuwjx. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Colstuwjx The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
BTW, on my laptop, I still could see some error messages output for kubeadm related issue while execute
|
Codecov Report
@@ Coverage Diff @@
## master #6105 +/- ##
==========================================
+ Coverage 36.7% 36.71% +<.01%
==========================================
Files 113 113
Lines 8355 8361 +6
==========================================
+ Hits 3067 3070 +3
- Misses 4887 4890 +3
Partials 401 401
|
Offline support is supposed to work by default without user intervention, so I would prefer to not add a flag unless necessary. #6111 should also rectify the issue. |
Yes, I agree. |
This PR is going to fixes #6103 by introducing a new config option
use-local-cached-images
, it will load local cached images without fetching images, and make minikube works well inside no-public-network-access environment.