Experimental Docker support (kic) using the Kind image #6151

medyagh · 2019-12-23T08:27:37Z

Merry Xmas ☀️! this PR is in a merg-able state by xmas ! the experimental version of KIC is ready to try !

All handmade Persian Carpets have one intentional mistake in them to imply no human is perfect !
this PR has more than one one mistake and none of them are intentional . 🙃

Give it a try:

./out/minikube start --vm-driver=docker

This PR reuses the ideas and Docker image provided by https://kind.sigs.k8s.io/

k8s-ci-robot · 2019-12-23T08:28:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

medyagh · 2019-12-23T10:36:37Z

/ok-to-test

minikube-bot · 2019-12-23T10:39:33Z

Error: running mkcmp: exit status 1

tejal29

This is a HUGEEE PR!!
I was wondering if you could break this into multiple PRs by functionality and refactors.
e.g.

First a very small PR with just the refactors
pkg/minikube/bootstrapper/kubeadmin/rbac -> pkg/minikube/bootstrapper/bsutil and add a new file for each version in the pkg/minikube/bootstrapper/bsutil/template
Refactor coded addAddOns to bsutils.AddAddOns
you have a bunch of file changes with spaces fixes e.g. "cmd/minikube/cmd/config/configure.go", pkg/util/crypto.go and pkg/minikube/service/service_test.go. Can you create a separate PR to fixes this style for all files ? or configure your editor to not change these.
Refactor from APIServerPort to HostBindPort and using constants.APIServerPort. They look independent to this PR.
Implement the unimplemented methods in kicbs with tests added if required.
Finally add the command line flags and Dockerfiles i.e the user facing changes.

This might take time but all of 1 to 4 can be done in parallel and then once the first 4 PRs are merged, you can submit 5.

pkg/drivers/kic/kic.go

pkg/minikube/bootstrapper/kicbs/kicbs.go

pkg/minikube/bootstrapper/bsutil/template/v1alpha1.go

minikube-bot · 2020-01-08T23:54:34Z

All Times minikube: [ 126.594255 127.899829 125.960533]
All Times Minikube (PR 6151): [ 114.751294 116.118168 126.659380]

Average minikube: 126.818206
Average Minikube (PR 6151): 119.176281

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6151) |
+----------------------+-----------+--------------------+
| minikube v           |  0.471963 |           0.515067 |
| Creating kvm2        | 48.727956 |          47.114548 |
| Preparing Kubernetes | 50.486031 |          45.825879 |
| Pulling images       |  3.561868 |           2.658862 |
| Launching Kubernetes | 20.740215 |          20.228388 |
| Waiting for cluster  |  2.780997 |           2.711229 |
| Done                 |           |                    |
|                      |  0.049176 |           0.048494 |
+----------------------+-----------+--------------------+

minikube-bot · 2020-01-09T00:27:47Z

All Times minikube: [ 127.922207 127.134146 128.197147]
All Times Minikube (PR 6151): [ 124.965072 127.212973 129.919290]

Average Minikube (PR 6151): 127.365778
Average minikube: 127.751167

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6151) |
+----------------------+-----------+--------------------+
| minikube v           |  0.546043 |           0.510041 |
| Creating kvm2        | 48.345045 |          47.450281 |
| Preparing Kubernetes | 51.526216 |          51.546666 |
| Pulling images       |  2.730415 |           3.360069 |
| Launching Kubernetes | 21.635525 |          21.649363 |
| Waiting for cluster  |  2.915403 |           2.743992 |
| Done                 |           |                    |
|                      |  0.051450 |           0.049959 |
+----------------------+-----------+--------------------+

minikube-bot · 2020-01-09T01:21:07Z

All Times minikube: [ 124.522627 123.938520 126.785512]
All Times Minikube (PR 6151): [ 127.315114 126.179752 127.056396]

Average Minikube (PR 6151): 126.850421
Average minikube: 125.082220

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6151) |
+----------------------+-----------+--------------------+
| minikube v           |  0.529740 |           0.471165 |
| Creating kvm2        | 47.449292 |          47.625450 |
| Preparing Kubernetes | 50.469936 |          50.953082 |
| Pulling images       |  2.652772 |           3.218021 |
| Launching Kubernetes | 21.024216 |          21.881906 |
| Waiting for cluster  |  2.905959 |           2.575938 |
| Done                 |           |                    |
|                      |  0.050305 |           0.081324 |
+----------------------+-----------+--------------------+

minikube-bot · 2020-01-09T23:54:36Z

All Times minikube: [ 121.445702 121.219874 121.836477]
All Times Minikube (PR 6151): [ 123.489973 125.979571 120.334612]

Average minikube: 121.500684
Average Minikube (PR 6151): 123.268052

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6151) |
+----------------------+-----------+--------------------+
| minikube v           |  0.413713 |           0.426823 |
| Creating kvm2        | 46.043660 |          45.539637 |
| Preparing Kubernetes | 49.855448 |          50.489134 |
| Pulling images       |  2.963459 |           2.928665 |
| Launching Kubernetes | 19.592326 |          21.041596 |
| Waiting for cluster  |  2.589711 |           2.720798 |
| Done                 |           |                    |
|                      |  0.042366 |           0.109580 |
+----------------------+-----------+--------------------+

codecov-io · 2020-01-10T00:06:26Z

Codecov Report

Merging #6151 into master will decrease coverage by 0.3%.
The diff coverage is 53.74%.

@@            Coverage Diff             @@
##           master    #6151      +/-   ##
==========================================
- Coverage    38.5%   38.19%   -0.31%     
==========================================
  Files         122      124       +2     
  Lines        8145     8223      +78     
==========================================
+ Hits         3136     3141       +5     
- Misses       4600     4674      +74     
+ Partials      409      408       -1

Impacted Files	Coverage Δ
pkg/minikube/bootstrapper/bsutil/binaries.go	`13.33% <ø> (ø)`	⬆️
pkg/minikube/bootstrapper/bsutil/featuregates.go	`84% <ø> (ø)`	⬆️
pkg/minikube/bootstrapper/bsutil/extraconfig.go	`79.1% <ø> (ø)`	⬆️
pkg/util/constants.go	`87.5% <ø> (ø)`	⬆️
pkg/minikube/bootstrapper/images/kic.go	`0% <0%> (ø)`
pkg/minikube/bootstrapper/bootstrapper.go	`0% <0%> (ø)`	⬆️
pkg/minikube/bootstrapper/bsutil/rbac.go	`0% <0%> (ø)`
pkg/minikube/bootstrapper/bsutil/kubelet.go	`53.84% <0%> (ø)`	⬆️
pkg/minikube/bootstrapper/bsutil/files.go	`0% <0%> (ø)`	⬆️
pkg/minikube/command/kic_runner.go	`0% <0%> (ø)`	⬆️
... and 13 more

minikube-bot · 2020-01-10T00:17:14Z

All Times minikube: [ 125.153742 121.529237 121.751275]
All Times Minikube (PR 6151): [ 123.868428 123.445522 124.662100]

Average minikube: 122.811418
Average Minikube (PR 6151): 123.992017

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6151) |
+----------------------+-----------+--------------------+
| minikube v           |  0.431799 |           0.441809 |
| Creating kvm2        | 46.020522 |          46.131868 |
| Preparing Kubernetes | 50.647485 |          51.519886 |
| Pulling images       |  2.983188 |           2.707209 |
| Launching Kubernetes | 20.117316 |          20.321560 |
| Waiting for cluster  |  2.567320 |           2.741066 |
| Done                 |           |                    |
|                      |  0.043517 |           0.041427 |
+----------------------+-----------+--------------------+

minikube-bot · 2020-01-10T00:50:12Z

All Times minikube: [ 126.594585 123.794024 121.609659]
All Times Minikube (PR 6151): [ 125.264387 125.417119 122.604318]

Average minikube: 123.999423
Average Minikube (PR 6151): 124.428608

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6151) |
+----------------------+-----------+--------------------+
| minikube v           |  0.441055 |           0.414782 |
| Creating kvm2        | 45.833829 |          46.315628 |
| Preparing Kubernetes | 51.199053 |          52.006836 |
| Pulling images       |  3.090986 |           3.001950 |
| Launching Kubernetes | 20.494839 |          20.091600 |
| Waiting for cluster  |  2.897911 |           2.556194 |
| Done                 |           |                    |
|                      |  0.041750 |           0.041031 |
+----------------------+-----------+--------------------+

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 23, 2019

k8s-ci-robot requested review from afbjorklund and sharifelgamal December 23, 2019 08:27

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2019

medyagh requested a review from josedonizetti December 23, 2019 09:16

medyagh mentioned this pull request Dec 23, 2019

Trim kic base image #6152

Closed

medyagh requested a review from tstromberg December 23, 2019 09:39

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 23, 2019

medyagh changed the title ~~Experimental verison of kic~~ wip: Experimental verison of kic Dec 23, 2019

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 23, 2019

tejal29 reviewed Dec 23, 2019

View reviewed changes

pkg/drivers/kic/kic.go Outdated Show resolved Hide resolved

pkg/minikube/bootstrapper/kicbs/kicbs.go Show resolved Hide resolved

pkg/minikube/bootstrapper/kicbs/kicbs.go Outdated Show resolved Hide resolved

pkg/minikube/bootstrapper/bsutil/template/v1alpha1.go Outdated Show resolved Hide resolved

medyagh added 15 commits January 7, 2020 13:52

fix ocibinary

a358aff

implement setup certs for kicbs

ac97b51

Implement images list for kic

1de4adf

implement pull images for kicbs

af1b77a

move verify clusters to its own package

08c715a

Add start restart to kic bs

0b85aa9

add output to logs kubeadm init

ea207b3

Ignore iptables for kic and fix chmod +x permission

35c47b9

add flag for kic host binding port

6cf2554

Add overlay network for kic

c7bc61a

Add addons to kic too

4dd9866

Add podSubnet to templates

860ce25

add podsubnet to all tempaltes

ae45bb7

auto set podsubnet for kic improve none auto set

e9b7451

refactor api server verification

d298593

use api port for host binding port

40a011c

Fix unit tests and go tempalte block

890878b

medyagh added 10 commits January 8, 2020 17:21

fix unit tests kudebadm template crio

b9f5afa

fix image unittest

8403350

fix containerd tmplate unittest

9a16a52

fix testdata for cidr tmpl

b4fa45f

fix test data for containerd tmpl

2f3ad44

fix crio-options test data for new tmpl

aea63ba

fix test data for options for new tmpl

70f8b96

fix dns test data and also add tests for v17

2ed25c7

fix test data for default

381187f

fix test data for crio for new tmpl

7198566

lint code

9eb855a

medyagh changed the title ~~wip: Experimental verison of kic~~ Experimental verison of kic Jan 10, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2020

tstromberg approved these changes Jan 10, 2020

View reviewed changes

remove debugging message

b92c22e

rename verify pkg to kverify

59ecf3f

medyagh merged commit 19c8dde into kubernetes:master Jan 10, 2020

medyagh mentioned this pull request Jan 13, 2020

Add support for VM-free deployments using Docker #4389

Closed

medyagh deleted the kic_exp branch January 13, 2020 20:09

tstromberg changed the title ~~Experimental verison of kic~~ Experimental Docker driver support (kic) using the Kind image Jan 15, 2020

tstromberg changed the title ~~Experimental Docker driver support (kic) using the Kind image~~ Experimental Docker support (kic) using the Kind image Jan 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Experimental Docker support (kic) using the Kind image #6151

Experimental Docker support (kic) using the Kind image #6151

medyagh commented Dec 23, 2019 •

edited by tstromberg

Loading

k8s-ci-robot commented Dec 23, 2019

medyagh commented Dec 23, 2019

minikube-bot commented Dec 23, 2019

tejal29 left a comment •

edited

Loading

minikube-bot commented Jan 8, 2020

minikube-bot commented Jan 9, 2020

minikube-bot commented Jan 9, 2020

minikube-bot commented Jan 9, 2020

codecov-io commented Jan 10, 2020 •

edited

Loading

minikube-bot commented Jan 10, 2020

minikube-bot commented Jan 10, 2020

Experimental Docker support (kic) using the Kind image #6151

Experimental Docker support (kic) using the Kind image #6151

Conversation

medyagh commented Dec 23, 2019 • edited by tstromberg Loading

k8s-ci-robot commented Dec 23, 2019

medyagh commented Dec 23, 2019

minikube-bot commented Dec 23, 2019

tejal29 left a comment • edited Loading

Choose a reason for hiding this comment

minikube-bot commented Jan 8, 2020

minikube-bot commented Jan 9, 2020

minikube-bot commented Jan 9, 2020

minikube-bot commented Jan 9, 2020

codecov-io commented Jan 10, 2020 • edited Loading

Codecov Report

minikube-bot commented Jan 10, 2020

minikube-bot commented Jan 10, 2020

medyagh commented Dec 23, 2019 •

edited by tstromberg

Loading

tejal29 left a comment •

edited

Loading

codecov-io commented Jan 10, 2020 •

edited

Loading