Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --dry-run option to start #6256

Merged
merged 3 commits into from
Jan 13, 2020
Merged

Add --dry-run option to start #6256

merged 3 commits into from
Jan 13, 2020

Conversation

tstromberg
Copy link
Contributor

Fixes #5181

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 9, 2020
@tstromberg tstromberg requested a review from medyagh January 9, 2020 19:14
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 9, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2020
@k8s-ci-robot k8s-ci-robot requested a review from RA489 January 9, 2020 19:15
@minikube-bot
Copy link
Collaborator

All Times minikube: [ 124.233010 114.045000 125.964350]
All Times Minikube (PR 6256): [ 125.879762 127.446652 128.986058]

Average minikube: 121.414120
Average Minikube (PR 6256): 127.437491

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6256) |
+----------------------+-----------+--------------------+
| minikube v           |  0.528210 |           0.454301 |
| Creating kvm2        | 47.020771 |          47.274202 |
| Preparing Kubernetes | 48.118965 |          51.599532 |
| Pulling images       |  2.980088 |           3.043640 |
| Launching Kubernetes | 19.991864 |          21.937589 |
| Waiting for cluster  |  2.723737 |           3.082588 |
| Done                 |           |                    |
|                      |  0.050124 |           0.045639 |
+----------------------+-----------+--------------------+

@minikube-bot
Copy link
Collaborator

All Times minikube: [ 124.659927 113.292924 123.558179]
All Times Minikube (PR 6256): [ 126.748980 126.794667 129.626620]

Average minikube: 120.503677
Average Minikube (PR 6256): 127.723422

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6256) |
+----------------------+-----------+--------------------+
| minikube v           |  0.517689 |           0.480442 |
| Creating kvm2        | 46.762702 |          47.610040 |
| Preparing Kubernetes | 46.630879 |          51.213671 |
| Pulling images       |  2.894557 |           3.625149 |
| Launching Kubernetes | 20.903874 |          21.843072 |
| Waiting for cluster  |  2.745070 |           2.902915 |
| Done                 |           |                    |
|                      |  0.052066 |           0.048135 |
+----------------------+-----------+--------------------+

medyagh
medyagh reviewed Jan 9, 2020
View reviewed changes
cmd/minikube/cmd/start.go
@@ -158,6 +159,7 @@ func initMinikubeFlags() {

startCmd.Flags().Bool(force, false, "Force minikube to perform possibly dangerous operations")
startCmd.Flags().Bool(interactive, true, "Allow user prompts for more information")
startCmd.Flags().Bool(dryRun, false, "dry-run mode. Validates configuration, but does does not mutate system state")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, maybe say more explicitly what you mean by system state.
either here or in a doc on the site.

@medyagh medyagh merged commit 8718a54 into kubernetes:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@RA489 RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add --dry-run flag to surface configuration warnings
4 participants
@tstromberg @k8s-ci-robot @minikube-bot @medyagh