Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "addon list" by viewing as a table #6274

Merged
merged 3 commits into from
Jan 13, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Jan 10, 2020

  • display addon list as a table (consistent with profile list and service list)
  • also if user has more than one profile, it will hint them to specify the profile
  • add a field to json (profile)
  • remove the --format option for addon list

Before this PR:

- addon-manager: enabled
- dashboard: disabled
- default-storageclass: enabled
- efk: disabled
- freshpod: disabled
- gvisor: disabled
- heapster: disabled
- helm-tiller: disabled
- ingress: disabled
- ingress-dns: disabled
- logviewer: disabled
- metrics-server: disabled
- nvidia-driver-installer: disabled
- nvidia-gpu-device-plugin: disabled
- registry: disabled
- registry-creds: disabled
- storage-provisioner: enabled
- storage-provisioner-gluster: disabled

After this PR

|-----------------------------|----------|--------------|
|         ADDON NAME          | PROFILE  |    STATUS    |
|-----------------------------|----------|--------------|
| addon-manager               | minikube | enabled ✅   |
| dashboard                   | minikube | disabled     |
| default-storageclass        | minikube | enabled ✅   |
| efk                         | minikube | disabled     |
| freshpod                    | minikube | disabled     |
| gvisor                      | minikube | disabled     |
| helm-tiller                 | minikube | disabled     |
| ingress                     | minikube | disabled     |
| ingress-dns                 | minikube | disabled     |
| istio                       | minikube | disabled     |
| istio-provisioner           | minikube | enabled ✅   |
| logviewer                   | minikube | disabled     |
| metrics-server              | minikube | disabled     |
| nvidia-driver-installer     | minikube | disabled     |
| nvidia-gpu-device-plugin    | minikube | disabled     |
| registry                    | minikube | disabled     |
| registry-creds              | minikube | disabled     |
| storage-provisioner         | minikube | enabled ✅   |
| storage-provisioner-gluster | minikube | disabled     |
|-----------------------------|----------|--------------|

if more user has more than 1 profile

$ ./out/minikube addons list
|-----------------------------|----------|--------------|
|         ADDON NAME          | PROFILE  |    STATUS    |
|-----------------------------|----------|--------------|
| addon-manager               | minikube | enabled ✅   |
| dashboard                   | minikube | disabled     |
| default-storageclass        | minikube | enabled ✅   |
| efk                         | minikube | disabled     |
| freshpod                    | minikube | disabled     |
| gvisor                      | minikube | disabled     |
| helm-tiller                 | minikube | disabled     |
| ingress                     | minikube | disabled     |
| ingress-dns                 | minikube | disabled     |
| istio                       | minikube | disabled     |
| istio-provisioner           | minikube | enabled ✅   |
| logviewer                   | minikube | disabled     |
| metrics-server              | minikube | disabled     |
| nvidia-driver-installer     | minikube | disabled     |
| nvidia-gpu-device-plugin    | minikube | disabled     |
| registry                    | minikube | disabled     |
| registry-creds              | minikube | disabled     |
| storage-provisioner         | minikube | enabled ✅   |
| storage-provisioner-gluster | minikube | disabled     |
|-----------------------------|----------|--------------|
💡  To see addons list for other profiles use: `minikube addons -p name list`

JSON output:

{"addon-manager":{"Profile":"minikube","Status":"enabled"},"dashboard":{"Profile":"minikube","Status":"disabled"},"default-storageclass":{"Profile":"minikube","Status":"enabled"},"efk":{"Profile":"minikube","Status":"disabled"},"freshpod":{"Profile":"minikube","Status":"disabled"},"gvisor":{"Profile":"minikube","Status":"disabled"},"helm-tiller":{"Profile":"minikube","Status":"disabled"},"ingress":{"Profile":"minikube","Status":"disabled"},"ingress-dns":{"Profile":"minikube","Status":"disabled"},"istio":{"Profile":"minikube","Status":"disabled"},"istio-provisioner":{"Profile":"minikube","Status":"enabled"},"logviewer":{"Profile":"minikube","Status":"disabled"},"metrics-server":{"Profile":"minikube","Status":"disabled"},"nvidia-driver-installer":{"Profile":"minikube","Status":"disabled"},"nvidia-gpu-device-plugin":{"Profile":"minikube","Status":"disabled"},"registry":{"Profile":"minikube","Status":"disabled"},"registry-creds":{"Profile":"minikube","Status":"disabled"},"storage-provisioner":{"Profile":"minikube","Status":"enabled"},"storage-provisioner-gluster":{"Profile":"minikube","Status":"disabled"}

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2020
@medyagh medyagh changed the title display addon list as a table Improve "addon list" by viewing as a table Jan 10, 2020
@medyagh
Copy link
Member Author

medyagh commented Jan 10, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 10, 2020
@codecov-io
Copy link

codecov-io commented Jan 10, 2020

Codecov Report

Merging #6274 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6274      +/-   ##
==========================================
- Coverage   38.28%   38.17%   -0.11%     
==========================================
  Files         124      124              
  Lines        8257     8262       +5     
==========================================
- Hits         3161     3154       -7     
- Misses       4686     4698      +12     
  Partials      410      410
Impacted Files Coverage Δ
cmd/minikube/cmd/config/profile_list.go 4.1% <ø> (ø) ⬆️
cmd/minikube/cmd/config/addons_list.go 11.76% <0%> (-12.05%) ⬇️

@minikube-bot
Copy link
Collaborator

All Times minikube: [ 126.980445 125.825548 122.068153]
All Times Minikube (PR 6274): [ 121.136144 112.522691 124.967254]

Average minikube: 124.958048
Average Minikube (PR 6274): 119.542030

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6274) |
+----------------------+-----------+--------------------+
| minikube v           |  0.420201 |           0.440557 |
| Creating kvm2        | 46.467415 |          45.657939 |
| Preparing Kubernetes | 50.407594 |          48.188376 |
| Pulling images       |  4.669008 |           2.725111 |
| Launching Kubernetes | 20.550843 |          19.605673 |
| Waiting for cluster  |  2.400354 |           2.881348 |
| Done                 |           |                    |
|                      |  0.042633 |           0.042187 |
+----------------------+-----------+--------------------+

@minikube-bot
Copy link
Collaborator

All Times minikube: [ 126.959842 127.916935 124.648073]
All Times Minikube (PR 6274): [ 126.704721 130.016031 112.356135]

Average minikube: 126.508283
Average Minikube (PR 6274): 123.025629

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6274) |
+----------------------+-----------+--------------------+
| minikube v           |  0.427928 |           0.460004 |
| Creating kvm2        | 47.973467 |          47.689506 |
| Preparing Kubernetes | 51.392066 |          48.114914 |
| Pulling images       |  3.037293 |           3.829837 |
| Launching Kubernetes | 21.054003 |          19.942659 |
| Waiting for cluster  |  2.577658 |           2.939938 |
| Done                 |           |                    |
|                      |  0.041591 |           0.048771 |
+----------------------+-----------+--------------------+

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 13, 2020
@minikube-bot
Copy link
Collaborator

All Times minikube: [ 120.915330 111.390300 124.661082]
All Times Minikube (PR 6274): [ 110.662705 123.851957 123.073893]

Average minikube: 118.988904
Average Minikube (PR 6274): 119.196185

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6274) |
+----------------------+-----------+--------------------+
| minikube v           |  0.309840 |           0.283580 |
| Creating kvm2        | 46.038691 |          45.382988 |
| Preparing Kubernetes | 47.642491 |          48.649476 |
| Pulling images       |  2.895111 |           2.561014 |
| Launching Kubernetes | 19.315101 |          19.702859 |
| Waiting for cluster  |  2.734854 |           2.566083 |
| Done                 |           |                    |
|                      |  0.055740 |           0.050454 |
+----------------------+-----------+--------------------+

@medyagh medyagh merged commit 2e3d3e0 into kubernetes:master Jan 13, 2020
@medyagh medyagh deleted the add_table branch May 2, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants