Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kubernetes libraries to v1.17.2 #6374

Merged
merged 3 commits into from
Jan 24, 2020

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Jan 22, 2020

Noticed our Kubernetes libraries were old while investigating #6373

One nice thing: with Kubernetes v1.17, we can now use 0.. tags instead of hashes.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2020
@codecov-io
Copy link

codecov-io commented Jan 22, 2020

Codecov Report

Merging #6374 into master will increase coverage by 0.07%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6374      +/-   ##
==========================================
+ Coverage    37.6%   37.67%   +0.07%     
==========================================
  Files         127      127              
  Lines        8562     8562              
==========================================
+ Hits         3220     3226       +6     
+ Misses       4923     4920       -3     
+ Partials      419      416       -3
Impacted Files Coverage Δ
cmd/minikube/cmd/mount.go 8.33% <ø> (ø) ⬆️
pkg/minikube/out/style.go 91.66% <ø> (ø) ⬆️
pkg/minikube/assets/addons.go 37.93% <ø> (ø) ⬆️
cmd/minikube/cmd/status.go 6.89% <0%> (ø) ⬆️
pkg/minikube/logs/logs.go 2.35% <0%> (ø) ⬆️
pkg/minikube/cluster/pause.go 0% <0%> (ø) ⬆️
pkg/addons/addons.go 26.05% <0%> (ø) ⬆️
cmd/minikube/cmd/root.go 55.03% <100%> (ø) ⬆️
pkg/minikube/cruntime/cruntime.go 62.16% <100%> (ø) ⬆️
pkg/minikube/cruntime/cri.go 38.57% <26.31%> (ø) ⬆️
... and 18 more

@minikube-pr-bot
Copy link

All Times Minikube (PR 6374): [ 117.835349 117.310956 113.034903]
All Times minikube: [ 115.735038 117.782328 135.883138]

Average minikube: 123.133501
Average Minikube (PR 6374): 116.060403

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6374) |
+----------------------+-----------+--------------------+
| minikube v           |  0.283422 |           0.291679 |
| Creating kvm2        | 41.046806 |          41.032238 |
| Preparing Kubernetes | 47.920370 |          47.696554 |
| Pulling images       |  3.665092 |           3.872432 |
| Launching Kubernetes | 26.934055 |          19.865832 |
| Waiting for cluster  |  2.714494 |           2.721108 |
+----------------------+-----------+--------------------+

@medyagh
Copy link
Member

medyagh commented Jan 23, 2020

/retest this please

pkg/drivers/none/none.go Show resolved Hide resolved
@medyagh
Copy link
Member

medyagh commented Jan 23, 2020

The test seem fine.

btw the dry-run limit 5s seems to be still too low, this test dry-run took 10s. maybe make it 13s

go.mod Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 99.153998 99.521288 95.921356]
All Times Minikube (PR 6374): [ 99.833845 98.804804 95.284201]

Average minikube: 98.198881
Average Minikube (PR 6374): 97.974284

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6374) |
+----------------------+-----------+--------------------+
| minikube v           |  0.346041 |           0.304005 |
| Creating kvm2        | 20.741275 |          20.014250 |
| Preparing Kubernetes | 49.548707 |          50.305780 |
| Pulling images       |  3.516973 |           3.851377 |
| Launching Kubernetes | 20.621044 |          20.138412 |
| Waiting for cluster  |  2.878991 |           2.738171 |
+----------------------+-----------+--------------------+

@tstromberg tstromberg merged commit 6fc7cb4 into kubernetes:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants