-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Kubernetes libraries to v1.17.2 #6374
Conversation
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #6374 +/- ##
==========================================
+ Coverage 37.6% 37.67% +0.07%
==========================================
Files 127 127
Lines 8562 8562
==========================================
+ Hits 3220 3226 +6
+ Misses 4923 4920 -3
+ Partials 419 416 -3
|
All Times Minikube (PR 6374): [ 117.835349 117.310956 113.034903] Average minikube: 123.133501 Averages Time Per Log
|
/retest this please |
The test seem fine. btw the dry-run limit 5s seems to be still too low, this test dry-run took 10s. maybe make it 13s |
All Times minikube: [ 99.153998 99.521288 95.921356] Average minikube: 98.198881 Averages Time Per Log
|
Noticed our Kubernetes libraries were old while investigating #6373
One nice thing: with Kubernetes v1.17, we can now use 0.. tags instead of hashes.