improve kic engine #6441

medyagh · 2020-01-30T23:56:44Z

refactor kic, get rid of node package, remove unused funcs, unexport things clean up, get rid of kic's node package #6396
detecet all containers created by kic using label (for better clean up)
be able to clean up kic even if user deleted profile and machine folders.
fix kic restart problem: kic: restart broken #6443
fix kic minikube status warnining kic: minikube status w wrong wranning #6410
closes delete with kic: stuck on "docker inspect -f {{.State.Status}} minikube" #6383
closes kic: minikube status w wrong wranning #6410
closes kic: restart broken #6443
closes clean up, get rid of kic's node package #6396

This PR is in a mergable state, please feel free to merge in my absense if it looks good to you.

k8s-ci-robot · 2020-01-30T23:58:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

codecov-io · 2020-01-31T01:10:22Z

Codecov Report

Merging #6441 into master will increase coverage by 0.01%.
The diff coverage is 52.38%.

@@            Coverage Diff             @@
##           master    #6441      +/-   ##
==========================================
+ Coverage   37.68%   37.69%   +0.01%     
==========================================
  Files         128      128              
  Lines        8654     8674      +20     
==========================================
+ Hits         3261     3270       +9     
- Misses       4970     4979       +9     
- Partials      423      425       +2

Impacted Files	Coverage Δ
pkg/minikube/cluster/cluster.go	`37.59% <0%> (-0.68%)`	⬇️
pkg/minikube/config/profile.go	`69.29% <84.61%> (+1.97%)`	⬆️
cmd/minikube/cmd/delete.go	`27.41% <0%> (-1.02%)`	⬇️

sharifelgamal

LGTM, just some nits.

pkg/drivers/kic/types.go

pkg/minikube/config/profile.go

medyagh · 2020-01-31T02:10:54Z

/ok-to-test

minikube-pr-bot · 2020-01-31T02:14:07Z

Error: running mkcmp: exit status 1

minikube-pr-bot · 2020-01-31T02:44:08Z

All Times minikube: [ 95.926872 94.470170 95.397701]
All Times Minikube (PR 6441): [ 95.428925 94.169041 95.835833]

Average Minikube (PR 6441): 95.144600
Average minikube: 95.264914

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6441) |
+----------------------+-----------+--------------------+
| minikube v           |  0.298506 |           0.285694 |
| Creating kvm2        | 19.797973 |          20.663571 |
| Preparing Kubernetes | 49.787544 |          47.927057 |
| Pulling images       |  3.694858 |           4.041492 |
| Launching Kubernetes | 18.912916 |          19.449613 |
| Waiting for cluster  |  2.722737 |           2.725440 |
+----------------------+-----------+--------------------+

minikube-pr-bot · 2020-01-31T03:34:18Z

All Times minikube: [ 95.867790 93.286408 94.530464]
All Times Minikube (PR 6441): [ 96.199899 93.655959 92.400302]

Average minikube: 94.561554
Average Minikube (PR 6441): 94.085387

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6441) |
+----------------------+-----------+--------------------+
| minikube v           |  0.308794 |           0.282818 |
| Creating kvm2        | 20.200925 |          20.248669 |
| Preparing Kubernetes | 49.225211 |          48.262123 |
| Pulling images       |  3.671031 |           3.961641 |
| Launching Kubernetes | 18.718038 |          18.369615 |
| Waiting for cluster  |  2.386084 |           2.910114 |
+----------------------+-----------+--------------------+

medyagh · 2020-01-31T04:32:24Z

created an issue for the cache integeration test failure #6445

minikube-pr-bot · 2020-01-31T04:54:53Z

All Times minikube: [ 93.923070 94.966001 95.073241]
All Times Minikube (PR 6441): [ 96.417049 94.450692 93.664918]

Average Minikube (PR 6441): 94.844220
Average minikube: 94.654104

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6441) |
+----------------------+-----------+--------------------+
| minikube v           |  0.300202 |           0.288106 |
| Creating kvm2        | 19.906288 |          19.708887 |
| Preparing Kubernetes | 48.989767 |          48.782428 |
| Pulling images       |  3.610835 |           3.940971 |
| Launching Kubernetes | 18.909269 |          19.344339 |
| Waiting for cluster  |  2.887913 |           2.729068 |
+----------------------+-----------+--------------------+

minikube-pr-bot · 2020-01-31T05:14:40Z

All Times minikube: [ 95.416723 93.655667 96.011758]
All Times Minikube (PR 6441): [ 94.323470 94.733609 93.840848]

Average minikube: 95.028049
Average Minikube (PR 6441): 94.299309

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6441) |
+----------------------+-----------+--------------------+
| minikube v           |  0.292774 |           0.289619 |
| Creating kvm2        | 19.744815 |          19.628591 |
| Preparing Kubernetes | 49.001844 |          49.076052 |
| Pulling images       |  3.615937 |           3.505789 |
| Launching Kubernetes | 19.603702 |          19.346196 |
| Waiting for cluster  |  2.718299 |           2.401863 |
+----------------------+-----------+--------------------+

minikube-pr-bot · 2020-01-31T05:54:48Z

All Times minikube: [ 96.728102 97.170769 96.069193]
All Times Minikube (PR 6441): [ 94.899581 93.708836 94.595336]

Average minikube: 96.656021
Average Minikube (PR 6441): 94.401251

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6441) |
+----------------------+-----------+--------------------+
| minikube v           |  0.310356 |           0.285199 |
| Creating kvm2        | 20.892773 |          19.708333 |
| Preparing Kubernetes | 49.128437 |          48.763428 |
| Pulling images       |  3.800456 |           3.815341 |
| Launching Kubernetes | 20.094277 |          18.881442 |
| Waiting for cluster  |  2.381710 |           2.898709 |
+----------------------+-----------+--------------------+

tstromberg · 2020-01-31T16:22:41Z

pkg/minikube/config/profile.go

@@ -165,6 +174,26 @@ func ListProfiles(miniHome ...string) (validPs []*Profile, inValidPs []*Profile,
 	return validPs, inValidPs, nil
 }

+// removeDupes removes duplicates


This is simple enough to just inline.

tstromberg · 2020-01-31T16:22:51Z

pkg/minikube/config/profile.go

+
+	for n := range profiles {
+		if seen[profiles[n]] {
+			// Do not add duplicate.


instead of an else, use a continue

medyagh changed the title ~~wip: detect all containers created by kic~~ wip: improve kic engine Jan 30, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2020

k8s-ci-robot requested review from blueelvis and priyawadhwa January 30, 2020 23:58

medyagh added 3 commits January 30, 2020 16:20

resolve conflict

8e0ffdf

delete all cleans up stale kic profiles

58b637b

add comment

5b055d7

medyagh force-pushed the kic_engine branch from 74f6d93 to 5b055d7 Compare January 31, 2020 01:02

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2020

remove duplicate profile names

e7fa3e0

sharifelgamal reviewed Jan 31, 2020

View reviewed changes

pkg/drivers/kic/types.go Outdated Show resolved Hide resolved

pkg/minikube/config/profile.go Outdated Show resolved Hide resolved

medyagh added 2 commits January 30, 2020 17:46

delete stale

80b4121

rename funcs

a709fd5

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 31, 2020

medyagh added 2 commits January 30, 2020 18:12

rename funcs

b20322a

rename createConfig

23e1256

medyagh added 2 commits January 30, 2020 18:24

fix kic restart use external ip

be38a02

fix kic minikube status

4f9df45

fix nil logic

7b3fa71

remove unused kic code

006c781

medyagh changed the title ~~wip: improve kic engine~~ improve kic engine Jan 31, 2020

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 31, 2020

medyagh added 2 commits January 30, 2020 21:01

unexport more funcs

968fe86

unexport noderolekey

a6ec05e

log warning if docker is stuck

0e5059d

medyagh requested a review from tstromberg January 31, 2020 05:38

gomod tidy

b46cdec

tstromberg suggested changes Jan 31, 2020

View reviewed changes

tstromberg merged commit d302b84 into kubernetes:master Jan 31, 2020

medyagh deleted the kic_engine branch May 2, 2020 22:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improve kic engine #6441

improve kic engine #6441

medyagh commented Jan 30, 2020 •

edited

Loading

k8s-ci-robot commented Jan 30, 2020

codecov-io commented Jan 31, 2020 •

edited

Loading

sharifelgamal left a comment

medyagh commented Jan 31, 2020

minikube-pr-bot commented Jan 31, 2020

minikube-pr-bot commented Jan 31, 2020

minikube-pr-bot commented Jan 31, 2020

medyagh commented Jan 31, 2020

minikube-pr-bot commented Jan 31, 2020

minikube-pr-bot commented Jan 31, 2020

minikube-pr-bot commented Jan 31, 2020

tstromberg Jan 31, 2020

tstromberg Jan 31, 2020

improve kic engine #6441

improve kic engine #6441

Conversation

medyagh commented Jan 30, 2020 • edited Loading

k8s-ci-robot commented Jan 30, 2020

codecov-io commented Jan 31, 2020 • edited Loading

Codecov Report

sharifelgamal left a comment

Choose a reason for hiding this comment

medyagh commented Jan 31, 2020

minikube-pr-bot commented Jan 31, 2020

minikube-pr-bot commented Jan 31, 2020

minikube-pr-bot commented Jan 31, 2020

medyagh commented Jan 31, 2020

minikube-pr-bot commented Jan 31, 2020

minikube-pr-bot commented Jan 31, 2020

minikube-pr-bot commented Jan 31, 2020

tstromberg Jan 31, 2020

Choose a reason for hiding this comment

tstromberg Jan 31, 2020

Choose a reason for hiding this comment

medyagh commented Jan 30, 2020 •

edited

Loading

codecov-io commented Jan 31, 2020 •

edited

Loading