Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split cluster package into multiple files #6484

Merged
merged 6 commits into from
Feb 4, 2020

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Feb 4, 2020

No functionality change: just splitting a gigantic file up to prepare for fixing #6479

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2020
@tstromberg tstromberg changed the title Split cluster package into multiple files WIP: Split cluster package into multiple files Feb 4, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2020
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making it easier to read the code

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2020
@tstromberg tstromberg changed the title WIP: Split cluster package into multiple files Split cluster package into multiple files Feb 4, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 4, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@bb539cb). Click here to learn what that means.
The diff coverage is 62.22%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6484   +/-   ##
=========================================
  Coverage          ?   37.81%           
=========================================
  Files             ?      138           
  Lines             ?     8745           
  Branches          ?        0           
=========================================
  Hits              ?     3307           
  Misses            ?     5017           
  Partials          ?      421
Impacted Files Coverage Δ
pkg/minikube/cluster/delete.go 37.5% <ø> (ø)
pkg/minikube/cluster/stop.go 25% <ø> (ø)
pkg/minikube/cluster/cluster.go 50% <ø> (ø)
pkg/minikube/cluster/docker_env.go 61.9% <ø> (ø)
pkg/minikube/cluster/ip.go 0% <ø> (ø)
pkg/minikube/cluster/iso.go 0% <ø> (ø)
pkg/minikube/cluster/status.go 36.36% <ø> (ø)
pkg/minikube/cluster/info.go 31.37% <ø> (ø)
pkg/minikube/cluster/ssh.go 42.85% <ø> (ø)
pkg/minikube/cluster/start.go 47.82% <ø> (ø)
... and 3 more

@minikube-pr-bot
Copy link

All Times Minikube (PR 6484): [ 99.676328 99.116067 94.824221]
All Times minikube: [ 98.082614 97.283176 100.029719]

Average Minikube (PR 6484): 97.872205
Average minikube: 98.465170

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6484) |
+----------------------+-----------+--------------------+
| minikube v           |  0.325515 |           0.293104 |
| Creating kvm2        | 20.311569 |          20.422813 |
| Preparing Kubernetes | 51.117875 |          50.675088 |
| Pulling images       |  3.866258 |           3.665200 |
| Launching Kubernetes | 19.840260 |          19.250372 |
| Waiting for cluster  |  1.409745 |           1.553541 |
+----------------------+-----------+--------------------+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants