Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kic: fix service list for docker on osx #6830

Merged
merged 1 commit into from
Feb 28, 2020
Merged

kic: fix service list for docker on osx #6830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions cmd/minikube/cmd/service_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,17 +66,18 @@ var serviceListCmd = &cobra.Command{
if len(serviceURL.URLs) == 0 {
data = append(data, []string{serviceURL.Namespace, serviceURL.Name, "No node port"})
} else {
data = append(data, []string{serviceURL.Namespace, serviceURL.Name, "", strings.Join(serviceURL.URLs, "\n")})
serviceURLs := strings.Join(serviceURL.URLs, "\n")

}
// if we are running Docker on OSX we empty the internal service URLs
if runtime.GOOS == "darwin" && cfg.Driver == oci.Docker {
serviceURLs = ""
}

}
service.PrintServiceList(os.Stdout, data)
if runtime.GOOS == "darwin" && cfg.Driver == oci.Docker {
out.FailureT("Accessing service is not implemented yet for docker driver on Mac.\nThe following issue is tracking the in progress work::\nhttps://github.com/kubernetes/minikube/issues/6778")
exit.WithCodeT(exit.Failure, "Not yet implemented for docker driver on MacOS.")
data = append(data, []string{serviceURL.Namespace, serviceURL.Name, "", serviceURLs})
}
}

service.PrintServiceList(os.Stdout, data)
},
}

Expand Down