Switch --vm-driver paramter to --driver

[sharifelgamal]

Fixes #6620

Anywhere where --vm-driver was accepted (minikube start and minikube config most notably), now --driver will be accepted. --vm-driver is still supported but deprecated and will be removed sometime in the future.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[medyagh]

/ok-to-test

[minikube-pr-bot]

All Times minikube: [ 87.741876 89.119282 90.187295]
All Times Minikube (PR 6888): [ 88.983960 91.391156 88.686630]

Average Minikube (PR 6888): 89.687249
Average minikube: 89.016151

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6888) |
+----------------------+-----------+--------------------+
| minikube v           |  0.220347 |           0.209447 |
| Creating kvm2        | 19.917135 |          20.220836 |
| Preparing Kubernetes | 46.961652 |          48.275263 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.663471 |          19.627837 |
| Waiting for cluster  |  0.048742 |           0.054539 |
+----------------------+-----------+--------------------+

[minikube-pr-bot]

All Times minikube: [ 90.880241 93.644633 88.886440]
All Times Minikube (PR 6888): [ 88.767471 91.508227 92.588244]

Average minikube: 91.137104
Average Minikube (PR 6888): 90.954647

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6888) |
+----------------------+-----------+--------------------+
| minikube v           |  0.206368 |           0.213040 |
| Creating kvm2        | 20.224151 |          20.089339 |
| Preparing Kubernetes | 49.097400 |          48.648699 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.070946 |          20.678451 |
| Waiting for cluster  |  0.229415 |           0.057181 |
+----------------------+-----------+--------------------+

[codecov-io]

Codecov Report

Merging #6888 into master will decrease coverage by 0.01%.
The diff coverage is 23.07%.

@@            Coverage Diff             @@
##           master    #6888      +/-   ##
==========================================
- Coverage   38.24%   38.23%   -0.02%     
==========================================
  Files         142      142              
  Lines        8753     8770      +17     
==========================================
+ Hits         3348     3353       +5     
- Misses       4984     4996      +12     
  Partials      421      421

Impacted Files	Coverage Δ
cmd/minikube/cmd/config/config.go	10.41% <ø> (ø)	⬆️
pkg/minikube/problem/err_map.go	100% <ø> (ø)	⬆️
cmd/minikube/cmd/start.go	32.62% <23.07%> (-0.13%)	⬇️
pkg/minikube/machine/fix.go	32.65% <0%> (+0.06%)	⬆️

[minikube-pr-bot]

All Times minikube: [ 90.004690 90.031304 91.506289]
All Times Minikube (PR 6888): [ 93.684745 90.137033 90.592475]

Average minikube: 90.514094
Average Minikube (PR 6888): 91.471418

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6888) |
+----------------------+-----------+--------------------+
| minikube v           |  0.217476 |           1.324935 |
| Creating kvm2        | 20.224813 |          20.032369 |
| Preparing Kubernetes | 48.611974 |          48.354780 |
| Pulling images       |           |                    |
| Launching Kubernetes | 19.860503 |          20.516948 |
| Waiting for cluster  |  0.222488 |           0.053997 |
+----------------------+-----------+--------------------+

[medyagh]

/ok-to-test

[minikube-pr-bot]

All Times minikube: [ 92.412958 90.028679 93.589648]
All Times Minikube (PR 6888): [ 92.151464 92.227390 94.113183]

Average minikube: 92.010428
Average Minikube (PR 6888): 92.830679

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6888) |
+----------------------+-----------+--------------------+
| minikube v           |  0.205782 |           0.377885 |
| Creating kvm2        | 19.929679 |          20.172895 |
| Preparing Kubernetes | 49.335885 |          48.936715 |
| Pulling images       |           |                    |
| Launching Kubernetes | 21.268818 |          22.133167 |
| Waiting for cluster  |  0.070784 |           0.061767 |
+----------------------+-----------+--------------------+