Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Korean translation #6910

Merged
merged 2 commits into from
Mar 6, 2020
Merged

Add Korean translation #6910

merged 2 commits into from
Mar 6, 2020

Conversation

anencore94
Copy link
Contributor

@anencore94 anencore94 commented Mar 6, 2020 •
edited
Loading

This PR includes 2 commits

  1. Update translations by 'make extract'
  2. Add some translations for korean

If there is any problem, please let me know. Thanks :)

anencore94 added 2 commits March 6, 2020 18:42
Update translations by 'make extract'
9d3a756 
- match translations file with code

Signed-off-by: anencore94 <anencore94@kaist.ac.kr>
Add translations for korean
c037ffb 
Signed-off-by: anencore94 <anencore94@kaist.ac.kr>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 6, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @anencore94. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 6, 2020
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anencore94
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anencore94
Copy link
Contributor Author

/assign @medyagh

@tstromberg
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 6, 2020
@tstromberg
Copy link
Contributor

Thank you for making minikube more accessible to the world!

@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@medyagh medyagh changed the title Ko translation Add Korean translation Mar 6, 2020
medyagh
medyagh approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much
대단히 감사합니다

@medyagh medyagh merged commit 5b7a7f2 into kubernetes:master Mar 6, 2020
@anencore94 anencore94 deleted the ko-translation branch March 6, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@tstromberg tstromberg tstromberg approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

Assignees

@medyagh medyagh

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anencore94 @k8s-ci-robot @minikube-bot @tstromberg @minikube-pr-bot @medyagh