Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow backwards compatibility with 1.6 and earlier configs #6969

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Allow backwards compatibility with 1.6 and earlier configs #6969

merged 1 commit into from
Mar 10, 2020

Conversation

sharifelgamal
Copy link
Collaborator

Fixes #6943

Now minikube will be able to retrieve older style configs and translate them to newer style.

@sharifelgamal sharifelgamal requested a review from medyagh March 9, 2020 19:10
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2020
@medyagh
Copy link
Member

medyagh commented Mar 9, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 9, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

tstromberg
tstromberg approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to get some testing around the ability to start from a v1.0 profile, as we are guaranteed to break it in the future.

@tstromberg tstromberg merged commit 4f5c882 into kubernetes:master Mar 10, 2020
@fmotrifork fmotrifork mentioned this pull request Mar 16, 2020
Merged
@afbjorklund afbjorklund mentioned this pull request Mar 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@medyagh medyagh Awaiting requested review from medyagh

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

@RA489 RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error getting primary cp: could not find master node
5 participants
@sharifelgamal @k8s-ci-robot @medyagh @minikube-pr-bot @tstromberg