Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add SysV init support #7081

Closed
wants to merge 25 commits into from
Closed

Conversation

tstromberg
Copy link
Contributor

My slightly crazy attempt to support SysV init systems like Upstart and OpenRC.

I only did this because I wanted to try minikube on Cloud Run.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 18, 2020
@k8s-ci-robot k8s-ci-robot requested review from blueelvis and RA489 March 18, 2020 00:15
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2020
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing it :) you are a hero

@afbjorklund
Copy link
Collaborator

Are those systems also missing the standard service wrapper ?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 22, 2020
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 2, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 3, 2020
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 4, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2020
@codecov-io
Copy link

Codecov Report

Merging #7081 into master will increase coverage by 0.12%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7081      +/-   ##
==========================================
+ Coverage   36.68%   36.80%   +0.12%     
==========================================
  Files         146      145       -1     
  Lines        8980     8957      -23     
==========================================
+ Hits         3294     3297       +3     
+ Misses       5294     5274      -20     
+ Partials      392      386       -6     
Impacted Files Coverage Δ
cmd/minikube/cmd/docker-env.go 49.47% <0.00%> (+1.02%) ⬆️
cmd/minikube/cmd/status.go 21.18% <0.00%> (+0.69%) ⬆️
pkg/minikube/bootstrapper/bootstrapper.go 0.00% <ø> (ø)
pkg/minikube/bootstrapper/bsutil/binaries.go 5.00% <0.00%> (-0.13%) ⬇️
pkg/minikube/cluster/pause.go 0.00% <0.00%> (ø)
pkg/minikube/cruntime/docker.go 28.16% <75.00%> (-0.49%) ⬇️
pkg/minikube/cruntime/containerd.go 43.26% <100.00%> (-0.49%) ⬇️
pkg/minikube/cruntime/crio.go 52.12% <100.00%> (+1.12%) ⬆️
pkg/minikube/cruntime/cruntime.go 67.92% <100.00%> (+10.42%) ⬆️

@tstromberg
Copy link
Contributor Author

Obsolete.

@tstromberg tstromberg closed this Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants