Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not override hostname if extraConfig is specified #7238

Merged
merged 2 commits into from
Mar 25, 2020
Merged

do not override hostname if extraConfig is specified #7238

merged 2 commits into from
Mar 25, 2020

Conversation

sharifelgamal
Copy link
Collaborator

Fixes #7161

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 25, 2020
@sharifelgamal sharifelgamal requested a review from medyagh March 25, 2020 21:08
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 25, 2020
@k8s-ci-robot k8s-ci-robot requested a review from blueelvis March 25, 2020 21:08
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2020
@medyagh
Copy link
Member

medyagh commented Mar 25, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 25, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@minikube-pr-bot
Copy link

All Times minikube: [ 67.315970 66.261976 65.788317]
All Times Minikube (PR 7238): [ 67.166251 63.854502 62.913095]

Average minikube: 66.455421
Average Minikube (PR 7238): 64.644616

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7238) |
+----------------------+-----------+--------------------+
| minikube v           |  0.133650 |           0.128035 |
| Creating kvm2        | 43.357429 |          41.193255 |
| Preparing Kubernetes | 21.061358 |          21.658666 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@sharifelgamal sharifelgamal merged commit 7100353 into kubernetes:master Mar 25, 2020
@fmotrifork fmotrifork mentioned this pull request Mar 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@medyagh medyagh Awaiting requested review from medyagh

@blueelvis blueelvis Awaiting requested review from blueelvis

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to override node-name: lookup minikube on x:53: no such host
5 participants
@sharifelgamal @k8s-ci-robot @medyagh @minikube-pr-bot @tstromberg