Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mustload: Replace DriverIP with Forwarded(IP|Port) #7310

Merged
merged 2 commits into from
Apr 1, 2020

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Mar 29, 2020

Fixes #7296 - a serious regression for supporting Docker on macOS.

I'm not sure how I missed this.

This PR obsoletes #7267

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from blueelvis and RA489 March 29, 2020 18:35
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 29, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 29, 2020
@codecov-io
Copy link

codecov-io commented Mar 29, 2020

Codecov Report

Merging #7310 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7310      +/-   ##
==========================================
- Coverage   37.47%   37.47%   -0.01%     
==========================================
  Files         146      146              
  Lines        8869     8870       +1     
==========================================
  Hits         3324     3324              
- Misses       5140     5141       +1     
  Partials      405      405              
Impacted Files Coverage Δ
cmd/minikube/cmd/docker-env.go 48.45% <0.00%> (ø)
cmd/minikube/cmd/ip.go 0.00% <0.00%> (ø)
cmd/minikube/cmd/logs.go 18.51% <0.00%> (ø)
cmd/minikube/cmd/mount.go 8.84% <0.00%> (ø)
cmd/minikube/cmd/podman-env.go 35.06% <0.00%> (ø)
cmd/minikube/cmd/ssh.go 12.50% <0.00%> (ø)
cmd/minikube/cmd/update-context.go 0.00% <0.00%> (ø)

@tstromberg tstromberg changed the title mustload: Check apiserver status using forwarded IP/port mustload: Replace DriverIP with Forwarded(IP|Port) Mar 29, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 63.843747 64.571736 63.382713]
All Times Minikube (PR 7310): [ 65.498433 65.128930 63.318467]

Average minikube: 63.932732
Average Minikube (PR 7310): 64.648610

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7310) |
+----------------------+-----------+--------------------+
| minikube v           |  0.226193 |           0.204853 |
| Creating kvm2        | 40.661609 |          40.574316 |
| Preparing Kubernetes | 21.456828 |          21.936304 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@tstromberg tstromberg requested a review from medyagh March 29, 2020 19:59
@tstromberg
Copy link
Contributor Author

@medyagh - question: on Linux, should we expose the true Docker IP & port, or is it better to always use 127.0.0.1 for consistency?

@medyagh
Copy link
Member

medyagh commented Mar 30, 2020

@tstromberg

@medyagh - question: on Linux, should we expose the true Docker IP & port, or is it better to always use 127.0.0.1 for consistency?

For sure it is better to use the real ip.
So at least on linux we have a true service port experience.
@josedonizetti told me about a POC that we could implement real ip for Mac in the future.

So I would consider macOs networking a limitation that we will eventually make it as nice as Linux.

@tstromberg
Copy link
Contributor Author

Merging and following up with a second PR to address shortcomings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker macOS: This control plane is not running! (state=Stopped)
5 participants