Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust warn if slow for ps and volume #7410

Merged
merged 3 commits into from
Apr 4, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Apr 4, 2020

closes #7408

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2020
@medyagh
Copy link
Member Author

medyagh commented Apr 4, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 4, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@medyagh medyagh force-pushed the adjust_warn_slow branch from ba2f69f to a0263c2 Compare April 4, 2020 03:59
@codecov-io
Copy link

Codecov Report

Merging #7410 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7410   +/-   ##
=======================================
  Coverage   37.07%   37.07%           
=======================================
  Files         146      146           
  Lines        8871     8871           
=======================================
  Hits         3289     3289           
  Misses       5193     5193           
  Partials      389      389           

@minikube-pr-bot
Copy link

All Times minikube: [ 72.440389 66.130570 65.622582]
All Times Minikube (PR 7410): [ 64.656380 65.911738 63.942958]

Average minikube: 68.064514
Average Minikube (PR 7410): 64.837026

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7410) |
+----------------------+-----------+--------------------+
| minikube v           |  0.270107 |           0.239724 |
| Creating kvm2        | 42.103241 |          40.327473 |
| Preparing Kubernetes | 23.104826 |          22.137143 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@tstromberg tstromberg merged commit 25cbb6e into kubernetes:master Apr 4, 2020
@medyagh medyagh deleted the adjust_warn_slow branch May 2, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adjust warn if slow for removing docker volumes
5 participants