-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addon registry-alias: change hosts update container image #7864
Conversation
The most recent Fedora image doesn't include a `diff` binary. This changes the container image to use Ubuntu Bionic instead, which _does_ provide a diff binary.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @tmehlinger! |
Hi @tmehlinger. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tmehlinger The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
Bump for CLA check. |
@@ -17,7 +17,7 @@ spec: | |||
spec: | |||
initContainers: | |||
- name: update | |||
image: registry.fedoraproject.org/fedora | |||
image: ubuntu:bionic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ubuntu ? could it be something smaller ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason in particular, that was just my workaround. I've changed it to Alpine 3.11 and fixed the diff command to account for the different between Busybox and GNU.
/ok-to-test |
kvm2 Driver |
Thank you! |
The most recent Fedora image doesn't include a
diff
binary. This changes the container image to use Ubuntu Bionic instead, which does provide a diff binary.Fixes #7715.