-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sort styles constant and style' map - continuation of bugfix/7792 #7902
Conversation
We have a number of style constant names defined in completly random order, let's make a little bit of cleanup here.
Hi @radeksm. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #7902 +/- ##
=======================================
Coverage 35.50% 35.50%
=======================================
Files 148 148
Lines 9330 9330
=======================================
Hits 3313 3313
Misses 5620 5620
Partials 397 397
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RA489, radeksm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
A little bit pf code cleanup, code hygiene, how important nowadays :)
While working on #7792 I found these two places where we have some large list of constants or mapping between constants' names and struct.
Sorting both of them makes the code more cleaner and much more easier to read.
fixes #7792