Detect windows container and exit with instructions #7984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
medyagh
changed the title
k8s-ci-robot
added
the
approved
medyagh
changed the title
medyagh
changed the title
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
kvm2 Driver Times for Minikube (PR 7984): [63.552057194999996 65.277374916 66.77798079700001] Averages Time Per Log docker Driver Times for Minikube (PR 7984): [28.253897865999992 27.808190374 28.95541597] Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 7984): [64.659989809 65.38544859199999 66.132769945] Averages Time Per Log docker Driver Times for Minikube (PR 7984): [27.880240106999995 28.080424021999992 28.038809752] Averages Time Per Log |
Codecov Report
@@ Coverage Diff @@
## master #7984 +/- ##
==========================================
- Coverage 36.04% 36.01% -0.04%
==========================================
Files 144 144
Lines 9196 9204 +8
==========================================
Hits 3315 3315
- Misses 5480 5488 +8
Partials 401 401
|
|
kvm2 Driver Times for Minikube (PR 7984): [65.995554508 65.227560903 65.857167564] Averages Time Per Log docker Driver Times for Minikube (PR 7984): [28.139059638 27.815587726000004 28.063274393999997] Averages Time Per Log |
medyagh
commented
May 3, 2020
| @@ -30,11 +30,20 @@ The Docker driver allows you to install Kubernetes into an existing Docker insta | |||
|
|
|||
| ## Troubleshooting | |||
|
|
|||
| - On macOS or Windows, you may need to restart Docker for Desktop if a command gets hung | |||
There was a problem hiding this comment.
note that this advice was already stated above and not needed to repeat.
|
kvm2 Driver Times for Minikube (PR 7984): [64.543399298 66.633368553 65.763454899] Averages Time Per Log docker Driver Times for Minikube (PR 7984): [27.811253516 27.365570623999997 28.433022647999998] Averages Time Per Log |
tstromberg
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7352
Before this PR
which the real problem was, the new docker desktop by default has Windows containers option "checked" during installation. so unless you change it, u will have windows conatiners.
After this PR: main scenario registry detects it
After this PR scenario 2: Rare but possible
( it has passed the registry- the container type been switched after minikube registry had evaluated the it as healthy)
(please mind this output was produced on Mac by flipping the If statement to genearte the error)