Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addons: fix initial retry delay, double maximum limit #7999

Merged
merged 1 commit into from
May 4, 2020

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented May 4, 2020

  • The initial retry delay was accidentally set to microseconds!
  • Double the maximum retry limit to 2 minutes to fight test flakes. This helps to ensure that addons are eventually deployed when requirements are met, without needing to understand what is required by each addon.

Fixes #7719

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 4, 2020
@tstromberg tstromberg requested a review from sharifelgamal May 4, 2020 19:46
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2020
@codecov-io
Copy link

Codecov Report

Merging #7999 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7999   +/-   ##
=======================================
  Coverage   36.04%   36.04%           
=======================================
  Files         144      144           
  Lines        9196     9196           
=======================================
  Hits         3315     3315           
  Misses       5480     5480           
  Partials      401      401           
Impacted Files Coverage Δ
pkg/addons/addons.go 43.97% <0.00%> (ø)

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do u mind putting in the PR description what u are trying to solve by increasing the time out? and do u have any good evidence increasing the time out might fix it?

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with skepticism. merge only if confident this is not a duck tape.

@tstromberg
Copy link
Contributor Author

Updated PR description.

@tstromberg tstromberg merged commit d363ca9 into kubernetes:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestErrorSpam: retry after the token is automatically created and added to the service account
4 participants