Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The podman cp command is not in podman-remote #8060

Merged
merged 1 commit into from
May 11, 2020

Conversation

afbjorklund
Copy link
Collaborator

So use podman exec stdin/stdout as a workaround.

@afbjorklund afbjorklund requested a review from medyagh May 10, 2020 12:19
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2020
So use podman exec stdin/stdout as a workaround.
@medyagh
Copy link
Member

medyagh commented May 11, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 11, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [66.214582612 62.008157322 64.69019682199999]
Average time for minikube: 64.304312252

Times for Minikube (PR 8060): [65.388932827 64.355938209 66.831672184]
Average time for Minikube (PR 8060): 65.52551440666667

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8060) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on   |  0.064051 |           0.061139 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.020254 |           0.019102 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003036 |           0.003041 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.795858 |          40.482007 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.1 | 20.351050 |          22.405614 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.721172 |           1.351359 |
| components...                  |           |                    |
| * Enabled addons:              |  0.269318 |           1.108204 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.076175 |           0.088876 |
| configured to use "minikube"   |           |                    |
|                                |  0.003399 |           0.006172 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [25.964636466 27.488613791 27.032772341]
Average time for minikube: 26.828674199333335

Times for Minikube (PR 8060): [27.203365614 27.800405499 25.306179391]
Average time for Minikube (PR 8060): 26.769983501333332

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8060) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on           |  0.074116 |           0.077016 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002938 |           0.002534 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.059056 |           0.060211 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.634240 |           7.692130 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.1         |  0.121006 |           0.119175 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.322908 |          17.642959 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.453523 |           1.106132 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.091509 |           0.002472 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.064950 |           0.062598 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004429 |           0.004757 |
+----------------------------------------+-----------+--------------------+

@medyagh medyagh merged commit d89d40c into kubernetes:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants