Fixed error parsing old version "latest" or "stable" #8230

kadern0 · 2020-05-21T10:18:59Z

Signed-off-by: kadern0 kaderno@gmail.com

Original issue output (consecutive runs):

./out/minikube start --kubernetes-version=v1.17.0
😄  minikube v1.9.2 on Ubuntu 20.04
✨  Automatically selected the docker driver

👍  Kubernetes 1.18.0 is now available. If you would like to upgrade, specify: --kubernetes-version=1.18.0
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating docker container (CPUs=2, Memory=3900MB) ...
🐳  Preparing Kubernetes v1.17.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
🌟  Enabling addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube"

 ./out/minikube start --kubernetes-version=stable
😄  minikube v1.9.2 on Ubuntu 20.04
✨  Using the docker driver based on existing profile
E0521 19:56:07.749663  209818 start.go:966] Error parsing old version "stable": No Major.Minor.Patch elements found
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🏃  Updating the running docker "minikube" container ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16

❌  [INVALID_KUBERNETES_VERSION] Failed to update cluster kubeadm images: semver: No Major.Minor.Patch elements found
💡  Suggestion: Specify --kubernetes-version in v<major>.<minor.<build> form. example: 'v1.1.14'

 ./out/minikube start --kubernetes-version=stable
😄  minikube v1.9.2 on Ubuntu 20.04
✨  Using the docker driver based on existing profile
E0521 19:56:12.539298  210499 start.go:966] Error parsing old version "stable": No Major.Minor.Patch elements found
E0521 19:56:12.539835  210499 start.go:966] Error parsing old version "stable": No Major.Minor.Patch elements found
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🏃  Updating the running docker "minikube" container ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16

❌  [INVALID_KUBERNETES_VERSION] Failed to update cluster kubeadm images: semver: No Major.Minor.Patch elements found
💡  Suggestion: Specify --kubernetes-version in v<major>.<minor.<build> form. example: 'v1.1.14'

./out/minikube start --kubernetes-version=latest
😄  minikube v1.9.2 on Ubuntu 20.04
✨  Using the docker driver based on existing profile
E0521 19:56:19.721802  211046 start.go:966] Error parsing old version "stable": No Major.Minor.Patch elements found
E0521 19:56:19.722759  211046 start.go:966] Error parsing old version "latest": No Major.Minor.Patch elements found
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🏃  Updating the running docker "minikube" container ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16

❌  [INVALID_KUBERNETES_VERSION] Failed to update cluster kubeadm images: semver: No Major.Minor.Patch elements found
💡  Suggestion: Specify --kubernetes-version in v<major>.<minor.<build> form. example: 'v1.1.14'

 ./out/minikube start --kubernetes-version=latest
😄  minikube v1.9.2 on Ubuntu 20.04
✨  Using the docker driver based on existing profile
E0521 19:56:24.988163  211418 start.go:966] Error parsing old version "latest": No Major.Minor.Patch elements found
E0521 19:56:24.988886  211418 start.go:966] Error parsing old version "latest": No Major.Minor.Patch elements found
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🏃  Updating the running docker "minikube" container ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16

❌  [INVALID_KUBERNETES_VERSION] Failed to update cluster kubeadm images: semver: No Major.Minor.Patch elements found
💡  Suggestion: Specify --kubernetes-version in v<major>.<minor.<build> form. example: 'v1.1.14'

Fixed code output:

./out/minikube start --kubernetes-version=v1.17.0
😄  minikube v1.9.2 on Ubuntu 20.04
✨  Automatically selected the docker driver
👍  Kubernetes 1.18.0 is now available. If you would like to upgrade, specify: --kubernetes-version=1.18.0
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating docker container (CPUs=2, Memory=3900MB) ...
🐳  Preparing Kubernetes v1.17.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
🌟  Enabling addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube"

 ./out/minikube start --kubernetes-version=stable
😄  minikube v1.9.2 on Ubuntu 20.04
✨  Using the docker driver based on existing profile
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🏃  Updating the running docker "minikube" container ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
🌟  Enabling addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube"

 ./out/minikube start --kubernetes-version=latest
😄  minikube v1.9.2 on Ubuntu 20.04
✨  Using the docker driver based on existing profile
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🏃  Updating the running docker "minikube" container ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
🌟  Enabling addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube"

 ./out/minikube start --kubernetes-version=latest
😄  minikube v1.9.2 on Ubuntu 20.04
✨  Using the docker driver based on existing profile
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🏃  Updating the running docker "minikube" container ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
🌟  Enabling addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube"

k8s-ci-robot · 2020-05-21T10:19:07Z

Hi @kadern0. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-05-21T10:19:19Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kadern0
To complete the pull request process, please assign sharifelgamal
You can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-bot · 2020-05-21T10:21:03Z

Can one of the admins verify this patch?

Fixes kubernetes#8210 Signed-off-by: kadern0 <kaderno@gmail.com>

k8s-ci-robot · 2020-05-21T10:55:38Z

Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

6189206 Fixed error parsing old version "latest" or "stable"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

codecov-commenter · 2020-05-21T11:50:13Z

Codecov Report

Merging #8230 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #8230      +/-   ##
==========================================
- Coverage   34.50%   34.48%   -0.03%     
==========================================
  Files         147      147              
  Lines        9412     9418       +6     
==========================================
  Hits         3248     3248              
- Misses       5765     5771       +6     
  Partials      399      399

Impacted Files	Coverage Δ
cmd/minikube/cmd/start_flags.go	`49.84% <0.00%> (-0.97%)`	⬇️

medyagh · 2020-05-21T17:01:21Z

thank you for fixing this ! @kadern0

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 21, 2020

k8s-ci-robot requested review from josedonizetti and tstromberg May 21, 2020 10:19

Fixed error parsing old version "latest" or "stable"

6189206

Fixes kubernetes#8210 Signed-off-by: kadern0 <kaderno@gmail.com>

kadern0 force-pushed the issue-8210 branch from ecf61be to 6189206 Compare May 21, 2020 10:55

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2020

medyagh approved these changes May 21, 2020

View reviewed changes

medyagh merged commit eea26ea into kubernetes:master May 21, 2020

fmotrifork mentioned this pull request Jun 2, 2020

minikube 1.11.0 fishworks/fish-food#764

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed error parsing old version "latest" or "stable" #8230

Fixed error parsing old version "latest" or "stable" #8230

kadern0 commented May 21, 2020

k8s-ci-robot commented May 21, 2020

k8s-ci-robot commented May 21, 2020

minikube-bot commented May 21, 2020

k8s-ci-robot commented May 21, 2020

codecov-commenter commented May 21, 2020

medyagh commented May 21, 2020

Fixed error parsing old version "latest" or "stable" #8230

Fixed error parsing old version "latest" or "stable" #8230

Conversation

kadern0 commented May 21, 2020

k8s-ci-robot commented May 21, 2020

k8s-ci-robot commented May 21, 2020

minikube-bot commented May 21, 2020

k8s-ci-robot commented May 21, 2020

codecov-commenter commented May 21, 2020

Codecov Report

medyagh commented May 21, 2020