add support for microsoft wsl for docker driver #8368

medyagh · 2020-06-03T21:41:31Z

have not tested myself but acording to this comment it works
#5392 (comment)

closes #7420
closes #5392

medyagh · 2020-06-03T21:41:41Z

/ok-to-test

k8s-ci-robot · 2020-06-03T21:42:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-pr-bot · 2020-06-03T21:44:42Z

kvm2 Driver
docker Driver

codecov-commenter · 2020-06-03T21:47:45Z

Codecov Report

Merging #8368 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #8368   +/-   ##
=======================================
  Coverage   34.64%   34.64%           
=======================================
  Files         151      151           
  Lines        9642     9641    -1     
=======================================
  Hits         3340     3340           
+ Misses       5900     5899    -1     
  Partials      402      402

Impacted Files	Coverage Δ
pkg/minikube/driver/driver.go	`58.87% <0.00%> (-1.13%)`	⬇️
cmd/minikube/cmd/config/configure.go	`1.48% <0.00%> (+0.03%)`	⬆️

minikube-pr-bot · 2020-06-03T22:04:30Z

kvm2 Driver
Times for minikube: [64.415013512 63.477016749 64.87191736599999]
Average time for minikube: 64.254649209

Times for Minikube (PR 8368): [64.757849563 63.199447897 65.965918705]
Average time for Minikube (PR 8368): 64.641072055

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8368) |
+--------------------------------+-----------+--------------------+
| * minikube v1.11.0 on Debian   |  0.061998 |           0.057818 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.022895 |           0.021530 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003324 |           0.009416 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.234083 |          41.291437 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 22.507218 |          21.196589 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.273849 |           1.321261 |
| components...                  |           |                    |
| * Enabled addons:              |  0.073519 |           0.667896 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.074325 |           0.070031 |
| configured to use "minikube"   |           |                    |
|                                |  0.003438 |           0.005094 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.225925268999998 25.172646604000004 27.371665152]
Average time for minikube: 26.590079008333333

Times for Minikube (PR 8368): [26.859646859999998 27.125531678 25.051801289000004]
Average time for Minikube (PR 8368): 26.34565994233333

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8368) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.11.0 on Debian           |  0.073715 |           0.072615 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002458 |           0.002487 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.060073 |           0.057984 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.482853 |           7.586423 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.3         |  0.118307 |           0.117646 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.672067 |          17.524101 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.112652 |           0.841094 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.002506 |           0.072401 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.062127 |           0.065693 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003321 |           0.005215 |
+----------------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-06-04T17:57:17Z

kvm2 Driver
Times for minikube: [67.33261575300001 61.16094738000001 61.762849834]
Average time for minikube: 63.41880432233334

Times for Minikube (PR 8368): [66.21633319 78.16188228699998 63.99270737599999]
Average time for Minikube (PR 8368): 69.45697428433333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8368) |
+--------------------------------+-----------+--------------------+
| * minikube v1.11.0 on Debian   |  0.053128 |           0.053980 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.018478 |           0.018290 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003243 |           0.003206 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 39.882578 |          39.492477 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 21.745319 |          28.051364 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.348544 |           1.293511 |
| components...                  |           |                    |
| * Enabled addons:              |  0.277829 |           0.473357 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.084602 |           0.067436 |
| configured to use "minikube"   |           |                    |
|                                |  0.005082 |           0.003353 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.561617323000004 26.806057780000003 25.704918261]
Average time for minikube: 26.357531121333334

Times for Minikube (PR 8368): [25.734885745 27.041690215000003 26.499494585]
Average time for Minikube (PR 8368): 26.425356848333337

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8368) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.11.0 on Debian           |  0.067689 |           0.063995 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002918 |           0.002412 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.059623 |           0.057684 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.760227 |           7.806006 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.3         |  0.119406 |           0.116510 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 16.897939 |          16.724342 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.381541 |           1.506609 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.002502 |           0.083609 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.062981 |           0.061153 |
| configured to use "minikube"           |           |                    |
|                                        |  0.002705 |           0.003036 |
+----------------------------------------+-----------+--------------------+

pkg/minikube/driver/driver.go

medyagh · 2020-06-04T18:46:02Z

/ok-to-test

minikube-pr-bot · 2020-06-04T18:56:21Z

kvm2 Driver
Times for minikube: [63.165993789 62.533050607 63.202849748000006]
Average time for minikube: 62.967298048

Times for Minikube (PR 8368): [61.151778387 59.423010826 60.881594211]
Average time for Minikube (PR 8368): 60.48546114133333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8368) |
+--------------------------------+-----------+--------------------+
| * minikube v1.11.0 on Debian   |  0.056030 |           0.055593 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019547 |           0.019405 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.005147 |           0.003487 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 39.170788 |          38.497045 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 21.625098 |          20.147328 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.584335 |           1.137177 |
| components...                  |           |                    |
| * Enabled addons:              |  0.421013 |           0.547030 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.080671 |           0.074976 |
| configured to use "minikube"   |           |                    |
|                                |  0.004668 |           0.003420 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.804580577 28.032271417999997 26.000153929]
Average time for minikube: 26.945668641333338

Times for Minikube (PR 8368): [26.896639797 25.415339448999998 26.958614856999997]
Average time for Minikube (PR 8368): 26.423531367666666

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8368) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.11.0 on Debian           |  0.067999 |           0.065007 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002710 |           0.002899 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.059537 |           0.057320 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.768588 |           7.522015 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.3         |  0.116277 |           0.115773 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.511647 |          17.826175 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.350024 |           0.764561 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.002660 |           0.002984 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.061684 |           0.063771 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004543 |           0.003027 |
+----------------------------------------+-----------+--------------------+

medyagh added 2 commits June 3, 2020 14:39

detect wsl and add port forward

02749de

improve comment

276f99b

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 3, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 3, 2020

k8s-ci-robot requested review from priyawadhwa and RA489 June 3, 2020 21:42

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2020

add more checks for wsl

98d577d

update comment

7b01b2a

nezorflame mentioned this pull request Jun 4, 2020

Support for Windows 10 WSL2 #5392

Closed

add hwlper to integraiotn test too

9e004d6

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 4, 2020

priyawadhwa reviewed Jun 4, 2020

View reviewed changes

pkg/minikube/driver/driver.go Outdated Show resolved Hide resolved

address review comments

6b29b78

medyagh requested a review from priyawadhwa June 4, 2020 18:39

priyawadhwa approved these changes Jun 4, 2020

View reviewed changes

medyagh merged commit 2011306 into kubernetes:master Jun 4, 2020

tstromberg mentioned this pull request Jun 4, 2020

Support external DOCKER_HOST from inside WSL #7420

Closed

medyagh deleted the detect_wsl branch March 2, 2021 21:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add support for microsoft wsl for docker driver #8368

add support for microsoft wsl for docker driver #8368

medyagh commented Jun 3, 2020 •

edited

Loading

medyagh commented Jun 3, 2020

k8s-ci-robot commented Jun 3, 2020

minikube-pr-bot commented Jun 3, 2020

codecov-commenter commented Jun 3, 2020 •

edited

Loading

minikube-pr-bot commented Jun 3, 2020

minikube-pr-bot commented Jun 4, 2020

medyagh commented Jun 4, 2020

minikube-pr-bot commented Jun 4, 2020

add support for microsoft wsl for docker driver #8368

add support for microsoft wsl for docker driver #8368

Conversation

medyagh commented Jun 3, 2020 • edited Loading

medyagh commented Jun 3, 2020

k8s-ci-robot commented Jun 3, 2020

minikube-pr-bot commented Jun 3, 2020

codecov-commenter commented Jun 3, 2020 • edited Loading

Codecov Report

minikube-pr-bot commented Jun 3, 2020

minikube-pr-bot commented Jun 4, 2020

medyagh commented Jun 4, 2020

minikube-pr-bot commented Jun 4, 2020

medyagh commented Jun 3, 2020 •

edited

Loading

codecov-commenter commented Jun 3, 2020 •

edited

Loading