docker: Choose the appropriate bridge interface when multiple exist #9062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @kadern0. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kadern0 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Can one of the admins verify this patch? |
Travis tests have failedHey @kadern0, 1st Buildmake testTravisBuddy Request Identifier: 9950b410-e449-11ea-ae1e-a7d25f4a9615 |
Travis tests have failedHey @kadern0, 1st Buildmake testTravisBuddy Request Identifier: 587e3e10-e44b-11ea-ae1e-a7d25f4a9615 |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
tstromberg
changed the title
tstromberg
changed the title
tstromberg
approved these changes
Aug 22, 2020
|
kvm2 Driver |
Travis tests have failedHey @kadern0, 1st Buildmake testTravisBuddy Request Identifier: c9c43790-e4d8-11ea-862b-338b6fa79dcf |
medyagh
requested changes
Aug 24, 2020
There was a problem hiding this comment.
the Docker Jenkins tests looks suspectious
Jenkins: completed with 41 / 182 failures in 39.68 minute(s).
https://storage.googleapis.com/minikube-builds/logs/9062/d98d5a7/Docker_Linux.html
@kadern0
here is the exact error
E0822 17:48:33.225866 17234 start.go:97] Unable to get host IP: unable to determine bridge network id from "eb45893fedc6"
*
X failed to start node: startup failed: Failed to setup kubeconfig: unable to determine bridge network id from "eb45893fedc6"
*
|
That's interesting. When I run this test locally, it passes: Although, I can see in this test that there was some issue with the network before reaching the new code part: Can you trigger another test to rule out any external issue that could have impacted the test? |
|
I think this PR will be obsolete by this #9094 |
|
@medyagh I've just tested it and it does start without any issue. Closing this PR. |
tstromberg
suggested changes
Sep 1, 2020
There was a problem hiding this comment.
I ran into this recently, so I got a chance to try out this PR. Since #9094 is still a WIP, I re-opened it in order to patch it in more easily. I've noted the two bugs that prevent this PR from working on Linux.
@medyagh - is #9094 something we plan to merge this week, or should we aim for this PR instead?
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
|
I can confirm that this fixes my issue. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pablo Caderno kaderno@gmail.com