-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dashboard to v2.0.3 #9129
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Travis tests have failedHey @tstromberg, 1st Buildmake test
TravisBuddy Request Identifier: 30b1c520-eb4c-11ea-95c6-05b7905ca42d |
Travis tests have failedHey @tstromberg, 1st Buildmake test
TravisBuddy Request Identifier: 4247abf0-ebb6-11ea-95c6-05b7905ca42d |
/ok-to-test |
kvm2 Driver Times for Minikube (PR 9129): 87.9s 77.2s 82.6s Averages Time Per Log
docker Driver Times for Minikube (PR 9129): 47.3s 46.3s 50.2s Averages Time Per Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ! I think you'll have to increase the preload version as well, since dashboard is currently included in the tarball
https://github.com/kubernetes/minikube/blob/master/pkg/minikube/download/preload.go#L44
We upgraded the dashboard image in kubernetes#9129, this will rebuild tarballs to include the latest version. This should also fix a small performance regression, where start time was increased by 25% on kvm2, probably becaues we were waiting for the new dashboard image to download. [PR bot comment](kubernetes#9129 (comment))
No description provided.