Make none driver work as regular user (use sudo on demand) #9379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
Welcome @Git-Jiro! |
|
Hi @Git-Jiro. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Git-Jiro The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
Travis tests have failedHey @Git-Jiro, 1st Buildmake test2nd BuildmakeTravisBuddy Request Identifier: 7d16af20-049c-11eb-a4bc-1b94c014fd22 |
|
Can one of the admins verify this patch? |
Git-Jiro
force-pushed
the
none_driver_nonroot
branch
from
8f76416 to
5fd7f48
Compare
Travis tests have failedHey @Git-Jiro, 1st Buildmake test2nd Buildmake test3rd BuildmakeTravisBuddy Request Identifier: c1160e40-065f-11eb-a99f-97db2ffc4a93 |
Git-Jiro
force-pushed
the
none_driver_nonroot
branch
from
fc8ea8d to
190d0a3
Compare
|
Hi @tstromberg! |
|
/retest |
|
@Git-Jiro: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@medyagh can you give me an ok-to-test? |
|
/retest |
|
@Git-Jiro: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/retest |
|
kvm2 Driver Times for Minikube (PR 9379): 59.5s 54.6s 61.3s Averages Time Per Log docker Driver Times for Minikube (PR 9379): 29.2s 27.1s 28.3s Averages Time Per Log |
|
/retest |
|
/skip |
|
/test ? |
|
@Git-Jiro: The following commands are available to trigger jobs:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-minikube-platform-tests |
|
@Git-Jiro: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
needs-rebase
Git-Jiro
force-pushed
the
none_driver_nonroot
branch
from
27e4c3e to
278a8cd
Compare
k8s-ci-robot
removed
the
needs-rebase
Codecov Report
@@ Coverage Diff @@
## master #9379 +/- ##
==========================================
- Coverage 29.05% 29.04% -0.01%
==========================================
Files 171 172 +1
Lines 10444 10488 +44
==========================================
+ Hits 3034 3046 +12
- Misses 6988 7017 +29
- Partials 422 425 +3
|
Git-Jiro
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
medyagh
requested changes
Oct 15, 2020
|
kvm2 Driver Times for Minikube (PR 9379): 61.8s 58.3s 62.2s Averages Time Per Log docker Driver Times for Minikube (PR 9379): 28.3s 29.2s 29.1s Averages Time Per Log |
tstromberg
suggested changes
Oct 21, 2020
|
Once everything is fine I will squash the commits. |
|
kvm2 Driver Times for Minikube (PR 9379): 68.3s 66.0s 67.2s Averages Time Per Log docker Driver Times for Minikube (PR 9379): 29.6s 30.9s 31.8s Averages Time Per Log |
tstromberg
reviewed
Oct 28, 2020
Git-Jiro
force-pushed
the
none_driver_nonroot
branch
from
e065c02 to
427daf6
Compare
|
kvm2 Driver Times for Minikube (PR 9379): 65.9s 63.4s 65.1s Averages Time Per Log docker Driver Times for Minikube (PR 9379): 29.2s 29.8s 31.4s Averages Time Per Log |
|
/ok-to-test |
priyawadhwa
reviewed
Nov 25, 2020
|
kvm2 Driver Times for Minikube (PR 9379): 60.5s 58.9s 58.2s Averages Time Per Log docker Driver Times for Minikube (PR 9379): 31.2s 29.0s 30.6s Averages Time Per Log |
|
Thank you! |
|
Seems to break normal usage, by requiring "sudo" for simple copy commands... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #3760
This almost works:
minikube start --vm-driver=none --kubernetes-version=1.17.0sudo chmod 711 /var/lib/minikube/binaries/v1.17.0/*minikube start --vm-driver=none --kubernetes-version=1.17.0minikube kubectl -- get pods -ASo the only open issue is how to properly set those permissions on /var/lib/minikube/binaries/v1.17.0/*